Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: A reusable tree-based web-visualization to browse EDAM ontology, and contribute to it. #591

Closed
whedon opened this issue Feb 20, 2018 · 58 comments
Closed

[PRE REVIEW]: A reusable tree-based web-visualization to browse EDAM ontology, and contribute to it. #591

whedon opened this issue Feb 20, 2018 · 58 comments
Assignees
@pjotrp
Labels
CSS HTML JavaScript pre-review

Comments

@whedon
Copy link

whedon commented Feb 20, 2018 •
edited
Loading

Submitting author: @bryan-brancotte (Bryan Brancotte)
Repository: https://github.com/IFB-ElixirFr/edam-browser
Version: v1.0.0
Editor: @pjotrp
Reviewers: @alexgarciac

Author instructions

Thanks for submitting your paper to JOSS @bryan-brancotte. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@bryan-brancotte if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Feb 20, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@bryan-brancotte
Copy link

Hi
The labels should be updated, Python should be removed and JavaScript added.
Best,

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@whedon
Copy link
Author

whedon commented Feb 20, 2018 

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Feb 20, 2018

--> Check article proof 📄 <--

@bryan-brancotte
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 28, 2018

I'm sorry @bryan-brancotte, I'm afraid I can't do that. That's something only editors are allowed to do.

@arfon
Copy link
Member

arfon commented Feb 28, 2018

@bryan-brancotte - we'll need to find an editor and a reviewer before we can start this review. This can sometimes find a couple of weeks.

Cheers
Arfon

@bryan-brancotte
Copy link

Sorry, for the inconvenience @arfon, I though that I had to do an action to initiate the search of editor and reviewer.

Regarding the labels, Python should be removed and JavaScript added.

Cheers
Bryan

@arfon
Copy link
Member

arfon commented Mar 13, 2018

Here's the compiled PDF: 10.21105.joss.00591.pdf

@hmenager
Copy link

thank you very much for providing the pdf @arfon

@bryan-brancotte
Copy link

Hi @arfon
Thanks for the pdf, I have done minor updates in the paper since its production, but the result it ok for us.

@arfon
Copy link
Member

arfon commented Mar 19, 2018

👋 @mgymrek - would you be willing to edit this submission for JOSS?

@jasonclark
Copy link

If you don't hear back from @mgymrek, I can help with the editing.

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

@whedon assign @jasonclark as reviewer

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

@whedon assign @jasonclark as editor

@whedon
Copy link
Author

whedon commented Mar 25, 2018

OK, the editor is @jasonclark

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

@whedon add @pjotrp as editor

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

Nice try. @arfon, two editors not allowed. @whedon is silent. @jasonclark I can help find a reviewer, or take over as an editor if you prefer.

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

Sorry I added you as an editor without asking - I wanted to add both of us.

@pjotrp
Copy link

pjotrp commented Mar 25, 2018

@alexgarciac offers to review the Edam browser.

@arfon
Copy link
Member

arfon commented Mar 25, 2018

Nice try. @arfon, two editors not allowed. @whedon is silent. @jasonclark I can help find a reviewer, or take over as an editor if you prefer.

Yes, this is expected. openjournals/whedon-api#25 only added support for multiple reviewers.

@pjotrp
Copy link

pjotrp commented Mar 28, 2018

@jasonclark ping

@arfon
Copy link
Member

arfon commented Apr 23, 2018

bump - what's the plan with this submission? Looks like we have a willing editor in @pjotrp and a reviewer in @alexgarciac.

@pjotrp - I suggest you move ahead with this.

@pjotrp
Copy link

pjotrp commented Apr 23, 2018

@jasonclark is nominally in charge. I was waiting for him to take charge or hand over. @arfon, if you can make me the editor I'll continue.

@arfon
Copy link
Member

arfon commented Apr 23, 2018

@whedon assign @pjotrp as editor

@whedon whedon assigned jasonclark and pjotrp and unassigned jasonclark Apr 23, 2018
@whedon
Copy link
Author

whedon commented Apr 23, 2018

OK, the editor is @pjotrp

@pjotrp
Copy link

pjotrp commented Apr 23, 2018

@whedon assign @alexgarciac as reviewer

@whedon whedon assigned pjotrp and unassigned pjotrp and jasonclark Apr 23, 2018
@whedon
Copy link
Author

whedon commented Apr 23, 2018

OK, the reviewer is @alexgarciac

@pjotrp
Copy link

pjotrp commented Apr 23, 2018

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Apr 23, 2018

OK, I've started the review over in #698. Feel free to close this issue now!

@pjotrp pjotrp closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjotrp pjotrp

Labels
CSS HTML JavaScript pre-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@arfon @pjotrp @jasonclark @hmenager @danielskatz @bryan-brancotte @whedon