-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Limbo: A Flexible High-performance Library for Gaussian Processes modeling and Data-Efficient Optimization #545
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @dfm it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
|
@dfm - thanks for agreeing to review this submission. Any questions along the way please shout! |
Hi all. I've had a crazy week so I probably won't get to this until next week. Please feel free to ping me if you don't hear anything from me by the end of next week. Sorry for the delay! |
Hi @dfm, |
Hi @dfm, Best regards, |
Friendly reminder to get to this sometime soonish @dfm |
👋 @dfm - any chance you can take a look at this soon? |
Ugh. Sorryyyy! This all looks great, but I haven't found time to actually go through and check all the boxes and give feedback. I will make sure that I do before the end of the day on Wednesday. Sorry again! |
Hi team, thank you so much for you patience here! I've gone through this and I've included some comments below. This is a really impressive piece of software and I am excited to use it in my own work. I think that there are a few things that could improve the documentation make everything consistent with the JOSS guidelines, but it shouldn't be too onerous. Installation:
Performance:
Documentation:
Thanks again for your patience! I hope that these comments are useful for improving the impact of this impressive library. Let me know if you have any questions. |
Thank you very much for your comments and your patience. We have addressed all of them and we believe that we made the documentation better. You can see the changes that we made in this pull request: resibots/limbo#257. Please, also find bellow our response to your comments: Installation:
Performance:
Documentation:
In general, we believe that your comments really helped us to improve the documentation and the library. We hope you will like these changes. Best regards, |
👋 @dfm - please take another look at this when you get a chance. |
@whedon set 10.5281/zenodo.1298561 as archive |
OK. 10.5281/zenodo.1298561 is the archive. |
@dfm - many thanks for your review here ✨ @jbmouret - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00545 ⚡️:rocket: :boom: |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippet:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @Aneoshun (Antoine Cully)
Repository: https://github.com/resibots/limbo
Version: V2.0
Editor: @arfon
Reviewer: @dfm
Archive: 10.5281/zenodo.1298561
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dfm, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arfon know.
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: