Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: tidyqpcr: Quantitative PCR analysis in the tidyverse. #4507

Closed
editorialbot opened this issue Jun 26, 2022 · 20 comments
Closed

[REVIEW]: tidyqpcr: Quantitative PCR analysis in the tidyverse. #4507

editorialbot opened this issue Jun 26, 2022 · 20 comments
Assignees
Labels
accepted published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci TeX

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 26, 2022

Submitting author: @ewallace (Edward Wallace)
Repository: https://github.com/ropensci/tidyqpcr
Branch with paper.md (empty if default branch):
Version: v1.0
Editor: @arfon
Reviewers: @arfon
Archive: 10.5281/zenodo.6757624

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/51996e6ce004532d31c0d83a6a806334"><img src="https://joss.theoj.org/papers/51996e6ce004532d31c0d83a6a806334/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/51996e6ce004532d31c0d83a6a806334/status.svg)](https://joss.theoj.org/papers/51996e6ce004532d31c0d83a6a806334)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@arfon, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@arfon, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (990.4 files/s, 155879.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               12            145            885            779
Rmd                              4            385            527            656
Markdown                         5            146              0            422
JSON                             1              0              0            233
YAML                             5             22              4            113
TeX                              1             13              0             77
-------------------------------------------------------------------------------
SUM:                            28            711           1416           2280
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 820

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1373/clinchem.2008.112797 is OK
- 10.7717/peerj.4473 is OK
- 10.1093/bioinformatics/btp578 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.1186/1471-2164-13-296/FIGURES/4 is INVALID

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon
Copy link
Member

arfon commented Jun 26, 2022

@ewallace – I'm going to move to accept this submission in JOSS given the earlier review in rOpenSci.

Before I do this though could you:

  • Take a look at fixing up the 10.1186/1471-2164-13-296/FIGURES/4 DOI? This looks to be invalid.
  • Please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
    • The title of the archive is the same as the JOSS paper title
    • That the authors of the archive are the same as the JOSS paper authors

I can then move forward with accepting the submission.

@ewallace
Copy link

Thank you @arfon!

I hope that all works.

@arfon
Copy link
Member

arfon commented Jun 27, 2022

@editorialbot set 10.5281/zenodo.6757624 as archive

@editorialbot
Copy link
Collaborator Author

Done! Archive is now 10.5281/zenodo.6757624

@arfon
Copy link
Member

arfon commented Jun 27, 2022

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1373/clinchem.2008.112797 is OK
- 10.7717/peerj.4473 is OK
- 10.1186/1471-2164-13-296 is OK
- 10.1093/bioinformatics/btp578 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#3314

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3314, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Jun 27, 2022
@arfon
Copy link
Member

arfon commented Jun 27, 2022

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.04507 joss-papers#3315
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.04507
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Jun 27, 2022
@arfon
Copy link
Member

arfon commented Jun 27, 2022

@ewallace – thanks for making those changes. Your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Jun 27, 2022
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.04507/status.svg)](https://doi.org/10.21105/joss.04507)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.04507">
  <img src="https://joss.theoj.org/papers/10.21105/joss.04507/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.04507/status.svg
   :target: https://doi.org/10.21105/joss.04507

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@ewallace
Copy link

Hello @arfon! Thank you very much for your help.

Unfortunately we have an issue with the proof, that it still has a "DRAFT" watermark. How can we fix that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS R recommend-accept Papers recommended for acceptance in JOSS. review rOpenSci Submissions associated with rOpenSci TeX
Projects
None yet
Development

No branches or pull requests

4 participants