Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: 3D Line Radiative Transfer & Synthetic Observations with Magritte #3863

Closed
whedon opened this issue Oct 27, 2021 · 25 comments
Closed

Comments

@whedon
Copy link

whedon commented Oct 27, 2021

Submitting author: @FredDeCeuster (Frederik De Ceuster)
Repository: https://github.com/Magritte-code/Magritte
Version: 0.0.1
Editor: @xuanxu
Reviewers: @gonsie, @CFGrote
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/010e408b39422f6691f876925e37d256"><img src="https://joss.theoj.org/papers/010e408b39422f6691f876925e37d256/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/010e408b39422f6691f876925e37d256/status.svg)](https://joss.theoj.org/papers/010e408b39422f6691f876925e37d256)

Author instructions

Thanks for submitting your paper to JOSS @FredDeCeuster. Currently, there isn't an JOSS editor assigned to your paper.

@FredDeCeuster if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Oct 27, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@kthyng
Copy link

kthyng commented Oct 27, 2021

@whedon check repository

@whedon
Copy link
Author

whedon commented Oct 27, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.27 s (613.8 files/s, 195961.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Jupyter Notebook                30              0          28651           6644
C++                             39           1587           2083           3936
Python                          23            952            503           3108
C/C++ Header                    31            538            289           1257
SVG                              4              0              0            946
CMake                            4             45             51            332
reStructuredText                15            197            156            234
Bourne Shell                     8             34             55            150
YAML                             3             18             57            110
Markdown                         6             24              0             79
-------------------------------------------------------------------------------
SUM:                           163           3395          31845          16796
-------------------------------------------------------------------------------


Statistical information for the repository 'ba46e4fd2aa89777efb663cc' was
gathered on 2021/10/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Frederik De Ceuster              1             1              1            0.00
FrederikDeCeuster              101         27849          17331          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Frederik De Ceuster       11604      1160400.0          9.7               17.63

@kthyng
Copy link

kthyng commented Oct 27, 2021

@whedon generate pdf from branch joss_paper_1.0

@whedon
Copy link
Author

whedon commented Oct 27, 2021

Attempting PDF compilation from custom branch joss_paper_1.0. Reticulating splines etc...

@kthyng
Copy link

kthyng commented Oct 27, 2021

@xuanxu would you be able to take this submission on as editor?

@kthyng
Copy link

kthyng commented Oct 27, 2021

@whedon invite @xuanxu as editor

@whedon
Copy link
Author

whedon commented Oct 27, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Oct 27, 2021

@xuanxu has been invited to edit this submission.

@xuanxu
Copy link
Member

xuanxu commented Oct 28, 2021

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Oct 28, 2021

OK, the editor is @xuanxu

@xuanxu
Copy link
Member

xuanxu commented Nov 3, 2021

@mdelorme, @gonsie would you be willing to review this paper? I think your knowledge of Simulation software and C++/Python makes both of you a good fit for this submission.

@gonsie
Copy link

gonsie commented Nov 3, 2021

I can review.

@xuanxu
Copy link
Member

xuanxu commented Nov 3, 2021

@whedon add @gonsie as reviewer

@whedon whedon assigned gonsie and xuanxu and unassigned xuanxu Nov 3, 2021
@whedon
Copy link
Author

whedon commented Nov 3, 2021

OK, @gonsie is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Nov 3, 2021

@gonsie great, thanks! I'll start the review issue once we have the second reviewer. Stay tuned!

@xuanxu
Copy link
Member

xuanxu commented Nov 12, 2021

@StanczakDominik would you be willing to review this paper? I think your knowledge of physics simulation software makes you a good fit for this submission.

@StanczakDominik
Copy link

Apologies,I'd love to and the package looks awesome from a glance, but I'm already overcommitted as it is at the moment :(

@xuanxu
Copy link
Member

xuanxu commented Nov 12, 2021

@CFGrote would you be willing to review this paper? I think your knowledge of physics and Python/C++ makes you a good fit for this submission.

@CFGrote
Copy link

CFGrote commented Nov 12, 2021 via email

@xuanxu
Copy link
Member

xuanxu commented Nov 12, 2021

@CFGrote great, thanks! I'll add you as reviewer and start the review issue right away

@xuanxu
Copy link
Member

xuanxu commented Nov 12, 2021

@whedon add @CFGrote as reviewer

@whedon whedon assigned CFGrote, gonsie and xuanxu and unassigned xuanxu and gonsie Nov 12, 2021
@whedon
Copy link
Author

whedon commented Nov 12, 2021

OK, @CFGrote is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Nov 12, 2021

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 12, 2021

OK, I've started the review over in #3905.

@whedon whedon closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants