-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: LinRegOutliers: A Julia package for detecting outliers in linear regression #2892
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @salleuska, @rMassimiliano it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
@salleuska, @rMassimiliano: Thanks for agreeing to review. Please carry out your review in this issue by updating the checklist above and giving feedback in this issue. The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. If possible create issues (and cross-reference) in the submission's repository to avoid too specific discussions in this review thread. If you have any questions or concerns please let me know. |
@salleuska, @rMassimiliano, would you mind giving a brief status of your progress? |
1 similar comment
@salleuska, @rMassimiliano, would you mind giving a brief status of your progress? |
👋 @salleuska, please update us on how your review is going. |
👋 @rMassimiliano, please update us on how your review is going. |
@mikldk Sorry for the late, I am working on this, and plan to get back to you with the review by the end of the week. |
Comments on the software repositoryI have some concerns regarding documentation of functions and examples, but I think these can be easily addressed by the author. My main concern is that the documentation should be expanded. Although each of the methods seems well referenced, few sentences describing what is the base idea of each algorithm would be helpful in my opinion. This also should help to clarify why some functions return different outputs ( I'll open a few more detailed issues in the repository to reference here, and make a separate comment related to Software Paper checklist. I admit that I have less familiarity with |
Software paperI think that the paper does not require major changes in the structure or language. I have just a few minor comments
|
Dear reviewer @salleuska, Thank you for your valuable suggestions, corrections, and comments. We will implement them. Thank you. |
@whedon generate pdf |
@whedon check references |
|
Dear reviewer @salleuska,
I think, these changes cover all your suggestions. Please, let me know, if there is anything missing or wrong. Thank you. |
I really like the new example section. I have some comments on the main paper and on the example section in the repository in the following. I tested the code on Julia 1.5.3 on Ubuntu. Paper Repository ( Sebert & Montgomery & Rollier (1998) Algorithm:
Peña and Yohai (1995)
While the current version would return
Least Trimmed Squares Regression |
Dear reviewer @rMassimiliano, Thank you very much for your comments.
|
Dear @jbytecode, However, the new version has not been added to Julia package registry I would recommend to add the new version to |
@jbytecode There are some confusing about the tags/releases in your repository ( If changed have been made since 0.8.4, then I recommend making this JOSS submission version 0.8.5 as the |
Dear editor @mikldk, It is just because the v0.8.4 was automatically created by the tag bot after publishing the latest revision in Julia repos. So I set the name of release 0.8.4, without a v prefix. Now, I am trying to create a new release, but zenodo throws an error of "New version's files must differ from all previous versions." what to do now ? edit: I created a small change and now I am trying to create a new release entry in zenodo. |
Dear editor @mikldk, It is okay. |
@whedon set 10.5281/zenodo.4419418 as archive |
OK. 10.5281/zenodo.4419418 is the archive. |
@whedon set v0.8.5 as version |
OK. v0.8.5 is the version. |
@whedon check references |
|
@whedon generate pdf |
@salleuska, @rMassimiliano Thank you very much for your effort in reviewing this paper! |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2012 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2012, then you can now move forward with accepting the submission by compiling again with the flag
|
@mikldk, @salleuska, and, @rMassimiliano, Thank you very much! Hope you all have a happy new year! |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@salleuska, @rMassimiliano - many thanks for your reviews here and to @mikldk for editing this submission. JOSS relies upon the volunteer efforts of folks like yourselves and we simply couldn't do it without you! @jbytecode - your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jbytecode (Mehmet Hakan Satman)
Repository: https://github.com/jbytecode/LinRegOutliers
Version: v0.8.5
Editor: @mikldk
Reviewers: @salleuska, @rMassimiliano
Archive: 10.5281/zenodo.4419418
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@salleuska & @rMassimiliano, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mikldk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @salleuska
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @rMassimiliano
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: