-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: The Gene School: Metagenomics #79
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @hughshanahan, @pschloss it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/jose-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Hi @hughshanahan, @pschloss: Thank you for agreeing to review for JOSE! This is where the action happens: please work your way through the review checklist, feel free to ask questions or post comments here, and also open issues in the submission repository as needed. I'm here to help, so please let me know if you need anything. Thanks! |
Hi @hughshanahan, @pschloss: I know we're in a difficult time, so I don't want to pressure. But I just wanted to check in with you both about your reviews. How are things going? Anything I can help with? |
Hi - aagh. Sorry for dropping the ball on this. I have interviews all day tomorrow and meetings on Wednesday morning. That gives Wednesday afternoon to get after this. Please be very rude to me if I don't get it done then. Sorry again. |
i'll do my best to get it up by the end of the week |
Can @emckiernan confirm that this is the correct review template? It seems to be for software rather than for teaching materials. I was expecting something more like what is given at #78 |
Also... what is the preferred way of leaving feedback on the authors' repository? One issue with checkboxes or separate issues for each point? |
Hi @pschloss, thanks for your question. I see your point, the review checklist is different from that provided at #78, and is missing sections like the one on pedagogy. This was automatically generated by whedon, so I'm not sure why it is different. Since this is my first time editing for JOSE, I'd like to loop in @labarba, just to make sure we're on the right track. Lorena, do you know why we have a different review template here? Thanks for any help! |
Hi @pschloss: The guidelines say, "Comments in the REVIEW issue should be kept brief, as much as possible, with more lengthy suggestions or requests posted as separate issues, directly in the submission repository." So I'd say, if the comments are short, you can leave something like a checklist, but if the comments are more lengthy, I'd open these as separate issues. You can link back to all of these in your review. Hope that helps! |
The checklist is auto-generated on the basis of the submission type chosen by the authors on the submission web form. @koadman — do you remember choosing the submission type from the drop-down menu back when you submitted? |
You can decide how you want to structure your feedback in the submission repository (whether to open one or several issues). But be sure to post here a link to the issue with a brief note, to create a cross-link. Note that this Review thread will be archived together with the paper at publication time, for posterity. |
Thanks @labarba, we appreciate the help! |
I have posted my review in the authors' repository. I have not completed the checklist above because I'm pretty confident it's the wrong one. I may have additional comments if a different checklist is given. |
@kyleniemeyer @labarba - looks like this is marked as |
@arfon yeah, I think that was a mistake that we didn't catch. This looks to be a learning module instead. Is that an easy fix, or do we just need to manually change the lists? |
I'm afraid this is a manual change to the lists so I think you are as well-positioned as I am to make this change :-) |
I have manually changed the review checklists. @pschloss — you'll have to go back and re-check items, I'm afraid. |
I've completed the checklist. I think it matches what I have written in my review in the repository. |
Hi @hughshanahan, just checking in about your review, thanks! |
Hi @hughshanahan, just checking in again, thanks! |
Hi @fbidu! You signed up to review for JOSE. Would you like to contribute a review for this submission? The title is "The Gene School: Metagenomics". Please let me know if you're available and willing. Thanks! |
I wonder whether @adina Howe might be interested in reviewing or would have suggestions on others that could provide a review. She works in this area. |
Yes, I am! I think that I have a friend that may be interested as well, can I invite him somehow? Thanks |
Great, thanks so much @fbidu! I'll add you as a reviewer and then insert a checklist for you above. Could you please send the contact information for your friend to my email emck31 at gmail? I can look it over and invite him if we need an extra reviewer. Thanks again! |
OK, @fbidu is now a reviewer |
Hi @fbidu, I've added a checklist for you at the top of this issue. Please let me know if you have any questions. Thanks! |
Hi @emckiernan - apologies, I have been ill. I think there is a problem with the template you created though - the URL link points to https://github.com/Nikoleta-v3/Game-Theory-and-Python - which is not the repo being discussed here - at the top of the page https://github.com/thegeneschool/metagenomics is mentioned. What is going on? |
Hi @pvanheus, no worries at all, I'm sorry to hear you were ill. I hope you're feeling better! And thank you for flagging the URL error. I'm not sure why the checklist originally generated by the bot linked to that repo. After that it was copy-paste errors when checklists were manually added. But you're right, the correct repository for review is https://github.com/thegeneschool/metagenomics. I can correct the links above. |
I see now! I think this was a copy-paste error early on when we changed the format of the checklist. All the links should point to the correct repository now. Thanks, @pvanheus! Tagging @fbidu in here, please check the repo link in your checklist to be sure all comments/issues are made on the correct repository. Thanks! |
@emckiernan I have submitted a much delayed review. I must admit that reviewing this material was not easy, but working through your checklist and considering the material from the perspective of someone who might want to adopt it helped in the end. I'll also note that I opened two issues (here and here) that have not been addressed by the authors since October. |
Thanks all, yes ready to move forward with revisions in the new year. Plenty to do here, thanks for the helpful feedback! |
Hi @koadman 👋 — do let us know how you are getting along with revising your submission! |
hi everyone 👋 — @emckiernan as editor, and @koadman as author — what do you think we should do here? This submission is stalled mid-review for many months. Is there a will to bring it to the finish line? Please let us know! |
Hi folks! Since we've had no reply from the authors for some time, I'm going to go ahead and pause this review. @koadman — Do let us know here if you would like to restart the review. |
@labarba oh my, this absolutely fell off of my radar, I'm sorry. I can review this on Saturday. Do you think it is still worth it? Thanks! |
Hi @fbidu, no worries, and thank you for your offer! We did get two reviewers in the end, so I think we're ok for now. However, if we need additional feedback at some point, I will definitely circle back to you. Thanks again! |
Submitting author: @koadman (Aaron Darling)
Repository: https://github.com/thegeneschool/metagenomics
Branch with paper.md (empty if default branch):
Version: v0.0.1
Editor: @emckiernan
Reviewers: @pschloss, @pvanheus, @fbidu
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hughshanahan & @pschloss, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emckiernan know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @hughshanahan
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @pschloss
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @erahulkulkarni
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @pvanheus
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @fbidu
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: