Skip to content

Commit aab07a4

Browse files
arun-josephkevinrushforth
authored andcommitted
8234239: [TEST_BUG] Reenable few ignored web tests
Reviewed-by: kcr
1 parent 95ad601 commit aab07a4

File tree

4 files changed

+4
-27
lines changed

4 files changed

+4
-27
lines changed

modules/javafx.web/src/test/java/test/com/sun/webkit/network/CookieManagerTest.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -37,7 +37,6 @@
3737
import java.util.Collections;
3838
import java.util.HashMap;
3939
import java.util.List;
40-
import org.junit.Ignore;
4140
import org.junit.Test;
4241
import static org.junit.Assert.assertEquals;
4342
import static org.junit.Assert.fail;
@@ -407,10 +406,7 @@ public void testPutOverwrite() {
407406

408407
/**
409408
* Tests if put() correctly overwrites expired cookie.
410-
* This test is disabled because it takes considerable amount of time
411-
* to run.
412409
*/
413-
@Ignore
414410
@Test
415411
public void testPutOverwriteExpired() {
416412
put("http://example.org/", "foo=bar; Max-Age=1; HttpOnly");
@@ -497,10 +493,7 @@ public void testPutPurgeDomain3() {
497493
/**
498494
* Tests if put() correctly purges individual domains
499495
* and takes into account cookie expiry.
500-
* This test is disabled because it takes considerable amount of time
501-
* to run.
502496
*/
503-
@Ignore
504497
@Test
505498
public void testPutPurgeDomainAfterExpiry() {
506499
for (int i = 0; i < 25; i++) {
@@ -547,10 +540,7 @@ public void testPutPurgeCookiesGlobally1() {
547540

548541
/**
549542
* Tests if put() correctly purges cookies globally.
550-
* This test is disabled because it takes considerable amount of time
551-
* to run.
552543
*/
553-
@Ignore
554544
@Test
555545
public void testPutPurgeCookiesGlobally2() {
556546
String urip = "http://example%d.org/";
@@ -579,10 +569,7 @@ public void testPutPurgeCookiesGlobally2() {
579569

580570
/**
581571
* Tests if put() correctly purges cookies globally.
582-
* This test is disabled because it takes considerable amount of time
583-
* to run.
584572
*/
585-
@Ignore
586573
@Test
587574
public void testPutPurgeCookiesGlobally3() {
588575
String urip = "http://example%d.org/";
@@ -612,10 +599,7 @@ public void testPutPurgeCookiesGlobally3() {
612599
/**
613600
* Tests if put() correctly purges cookies globally and takes
614601
* into account cookie expiry.
615-
* This test is disabled because it takes considerable amount of time
616-
* to run.
617602
*/
618-
@Ignore
619603
@Test
620604
public void testPutPurgeCookiesGloballyAfterExpiry() {
621605
String urip = "http://example%d.org/";

modules/javafx.web/src/test/java/test/javafx/scene/web/CallbackTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -42,7 +42,6 @@
4242
import javafx.scene.web.WebEvent;
4343
import javafx.util.Callback;
4444

45-
import org.junit.Ignore;
4645
import org.junit.Test;
4746

4847

@@ -88,7 +87,6 @@ private void clear() {
8887
popupUi.clear();
8988
}
9089

91-
@Ignore("RT-34508")
9290
@Test public void testDefaultPopup() {
9391
clear();
9492
executeScript(JS_OPEN_DEFAULT);
@@ -106,7 +104,6 @@ private void checkDefaultPopup() {
106104
popupUi.checkCalled(VISIBILITY_CHANGED, true);
107105
}
108106

109-
@Ignore("RT-34508")
110107
@Test public void testCustomPopup() {
111108
clear();
112109
executeScript(JS_OPEN);

modules/javafx.web/src/test/java/test/javafx/scene/web/LeakTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -45,7 +45,6 @@
4545
import javafx.scene.web.WebView;
4646
import javafx.util.Duration;
4747
import netscape.javascript.JSObject;
48-
import org.junit.Ignore;
4948
import org.junit.Test;
5049
import org.w3c.dom.Document;
5150
import org.w3c.dom.Element;
@@ -56,7 +55,6 @@ public class LeakTest extends TestBase {
5655

5756
private static final int SLEEP_TIME = 1000;
5857

59-
@Ignore // RT-26710: javafx.scene.web.LeakTest hangs
6058
@Test public void testOleg() throws InterruptedException{
6159
final String URL = new File("src/test/resources/test/html/guimark2-vector.html").toURI().toASCIIString();
6260
final int CYCLE_COUNT = 16;
@@ -65,7 +63,7 @@ public class LeakTest extends TestBase {
6563

6664
Timeline time = new Timeline();
6765
time.setCycleCount(CYCLE_LENGTH * CYCLE_COUNT);
68-
time.getKeyFrames().add(new KeyFrame(Duration.millis(1000), new EventHandler<ActionEvent>() {
66+
time.getKeyFrames().add(new KeyFrame(Duration.millis(200), new EventHandler<ActionEvent>() {
6967
int counter = -1;
7068
@Override public void handle(final ActionEvent e) {
7169
++counter;
@@ -82,7 +80,6 @@ public class LeakTest extends TestBase {
8280
latch.await();
8381
}
8482

85-
@Ignore // RT-26710: javafx.scene.web.LeakTest hangs
8683
@Test public void testGarbageCollectability() throws InterruptedException {
8784
final BlockingQueue<WeakReference<WebPage>> webPageRefQueue =
8885
new LinkedBlockingQueue<WeakReference<WebPage>>();

modules/javafx.web/src/test/java/test/javafx/scene/web/MiscellaneousTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ private static final class DummyClass {
9191
private static int dummyField;
9292
}
9393

94-
@org.junit.Ignore
9594
@Test public void testRT30835() throws Exception {
9695
class Record {
9796
private final Document document;

0 commit comments

Comments
 (0)