Skip to content

8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc69656
Backport 46251bc6e248a19e8d78173ff8d0502c68ee1acb
sercher Jun 4, 2025
3fc7e51
Backport 6e18883d8ffd9a7b7d495da05e9859dc1d1a2677
sercher Jun 7, 2025
4b63d53
Backport 91072ee3934616ab2edc4850a59c0a25fd0de3b4
sercher Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 66 additions & 30 deletions jdk/src/share/classes/javax/swing/plaf/basic/BasicOptionPaneUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public class BasicOptionPaneUI extends OptionPaneUI {
public static final int MinimumHeight = 90;

private static String newline;
private static int recursionCount;

/**
* <code>JOptionPane</code> that the receiver is providing the
Expand Down Expand Up @@ -317,6 +318,7 @@ protected Container createMessageArea() {
"OptionPane.messageAnchor", GridBagConstraints.CENTER);
cons.insets = new Insets(0,0,3,0);

recursionCount = 0;
addMessageComponents(body, cons, getMessage(),
getMaxCharactersPerLineCount(), false);
top.add(realBody, BorderLayout.CENTER);
Expand Down Expand Up @@ -391,41 +393,75 @@ protected void addMessageComponents(Container container,
} else if ((nl = s.indexOf('\n')) >= 0) {
nll = 1;
}
if (nl >= 0) {
// break up newlines
if (nl == 0) {
JPanel breakPanel = new JPanel() {
public Dimension getPreferredSize() {
Font f = getFont();

if (f != null) {
return new Dimension(1, f.getSize() + 2);
}
return new Dimension(0, 0);
}
};
breakPanel.setName("OptionPane.break");
addMessageComponents(container, cons, breakPanel, maxll,
true);
} else {
addMessageComponents(container, cons, s.substring(0, nl),
maxll, false);
if (s.contains("<html>")) {
/* line break in html text is done by <br> tag
* and not by /n so it's incorrect to address newline
* same as non-html text.
* Text between <html> </html> tags are extracted
* and rendered as JLabel text
*/
int index1 = s.indexOf("<html>");
int index2 = s.indexOf("</html>");
String str = "";
if (index2 >= 0) {
str = s.substring(index2 + "</html>".length());
s = s.substring(index1, index2 + + "</html>".length());
}
addMessageComponents(container, cons, s.substring(nl + nll), maxll,
false);

} else if (len > maxll) {
Container c = Box.createVerticalBox();
c.setName("OptionPane.verticalBox");
burstStringInto(c, s, maxll);
addMessageComponents(container, cons, c, maxll, true );

} else {
JLabel label;
label = new JLabel( s, JLabel.LEADING );
label = new JLabel(s, JLabel.LEADING);
label.setName("OptionPane.label");
configureMessageLabel(label);
addMessageComponents(container, cons, label, maxll, true);
if (!str.isEmpty()) {
addMessageComponents(container, cons, str, maxll, false);
}
} else {
if (nl >= 0) {
// break up newlines
if (nl == 0) {
@SuppressWarnings("serial") // anonymous class
JPanel breakPanel = new JPanel() {
public Dimension getPreferredSize() {
Font f = getFont();

if (f != null) {
return new Dimension(1, f.getSize() + 2);
}
return new Dimension(0, 0);
}
};
breakPanel.setName("OptionPane.break");
addMessageComponents(container, cons, breakPanel, maxll,
true);
} else {
addMessageComponents(container, cons, s.substring(0, nl),
maxll, false);
}
// Prevent recursion of more than
// 200 successive newlines in a message
// and indicate message is truncated via ellipsis
if (recursionCount++ > 200) {
recursionCount = 0;
addMessageComponents(container, cons, new String("..."),
maxll, false);
return;
}
addMessageComponents(container, cons, s.substring(nl + nll), maxll,
false);

} else if (len > maxll) {
Container c = Box.createVerticalBox();
c.setName("OptionPane.verticalBox");
burstStringInto(c, s, maxll);
addMessageComponents(container, cons, c, maxll, true);

} else {
JLabel label;
label = new JLabel(s, JLabel.LEADING);
label.setName("OptionPane.label");
configureMessageLabel(label);
addMessageComponents(container, cons, label, maxll, true);
}
}
}
}
Expand Down
91 changes: 91 additions & 0 deletions jdk/test/javax/swing/JOptionPane/TestJOptionHTMLTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/* @test
* @bug 5074006
* @key headful
* @library /java/awt/regtesthelpers
* @library /test/lib
* @summary Swing JOptionPane shows <html> tag as a string after newline
* @run main/manual TestJOptionHTMLTag
*/

import java.awt.BorderLayout;
import static java.awt.Dialog.ModalityType;

import javax.swing.JDialog;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JTextArea;
import javax.swing.SwingUtilities;

import jtreg.SkippedException;

public class TestJOptionHTMLTag {
static String instructions
= "INSTRUCTIONS:\n" +
" Read the text in the above panel.\n" +
" If it does not contain </html> string, press Pass else press Fail.\n";

private static boolean passed = false;
private static boolean skipped = false;
private static Thread mainThread = Thread.currentThread();
public static void main(String[] args) throws Exception {

try {
SwingUtilities.invokeLater(() -> {
String message = "<html>" + "This is a test\n" + "</html>\n\n\n\n";
JOptionPane optionPane = new JOptionPane();
optionPane.setMessage(message);
optionPane.setMessageType(JOptionPane.INFORMATION_MESSAGE);
optionPane.setOptions(new Object[]{"Pass", "Fail"});
JDialog dialog = optionPane.createDialog("Test");
dialog.setModalityType(ModalityType.TOOLKIT_MODAL);
dialog.setContentPane(optionPane);

JTextArea textArea = new JTextArea(instructions);
textArea.setEditable(false);
JPanel mainPanel = new JPanel(new BorderLayout());
mainPanel.add(textArea, BorderLayout.CENTER);
dialog.add(mainPanel);
dialog.pack();
dialog.show();
Object value = optionPane.getValue();
if (value == null) {
skipped = true;
} else if (value.equals("Pass")) {
passed = true;
}
mainThread.interrupt();
});
Thread.sleep(10000);
} catch (InterruptedException e) {
if (passed) {
return;
} else if (!skipped) {
throw new RuntimeException("Test failed.");
}
}
throw new SkippedException("Test skipped.");
}
}

59 changes: 59 additions & 0 deletions jdk/test/javax/swing/JOptionPane/TestOptionPaneStackOverflow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/* @test
@bug 8224267 8290162
@key headful
@summary Verifies if StackOverflowError is not thrown for multiple newlines
@run main TestOptionPaneStackOverflow
*/

import javax.swing.JDialog;
import javax.swing.JFrame;
import javax.swing.JOptionPane;
import javax.swing.SwingUtilities;

public class TestOptionPaneStackOverflow
{
static JFrame frame;

public static void main(String[] argv) throws Exception
{
try {
String message = java.nio.CharBuffer.allocate(5000).toString().
replace('\0','\n');
SwingUtilities.invokeAndWait(() -> {
frame = new JFrame();
JOptionPane optionPane = new JOptionPane();
optionPane.createDialog(frame, null);
optionPane.setMessage(message);
});
} finally {
SwingUtilities.invokeAndWait(() -> {
if (frame != null) {
frame.dispose();
}
});
}
}
}