8288021: Add hard test cases to jdk.internal.math.DoubleToDecimalChecker

[rgiulietti]

These 19'545 doubles were generated on purpose by Paul Zimmermann of INRIA as hard test cases.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288021: Add hard test cases to jdk.internal.math.DoubleToDecimalChecker

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Contributors

• Paul Zimmermann <Paul.Zimmermann@inria.fr>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9084/head:pull/9084
$ git checkout pull/9084

Update a local copy of the PR:
$ git checkout pull/9084
$ git pull https://git.openjdk.org/jdk pull/9084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9084

View PR using the GUI difftool:
$ git pr show -t 9084

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9084.diff

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0efa530e)

[rgiulietti]

/contributor add Paul Zimmermann Paul.Zimmermann@inria.fr

[openjdk]

@rgiulietti
Contributor Paul Zimmermann <Paul.Zimmermann@inria.fr> successfully added.

[rgiulietti]

Many of the test cases failed before PR3402, so it's worth having them in the codebase to detect regressions.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288021: Add hard test cases to jdk.internal.math.DoubleToDecimalChecker

Co-authored-by: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 257 new commits pushed to the master branch:

• 7905788: 8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
• 47fe9ef: 8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl
• 62e1e79: 8289147: unify os::infinite_sleep on posix platforms
• de74671: 8266670: Better modeling of access flags in core reflection
• a5c25d8: 8286395: Address possibly lossy conversions in java.security.jgss
• e93be3a: 8286389: Address possibly lossy conversions in jdk.crypto.ec
• 53b37fe: 8288130: compiler error with AP and explicit record accessor
• 0828881: 8289166: ProblemList tools/jlink/plugins/CompressorPluginTest.java
• 4cdb978: 8289098: clean up ported serviceability/jvmti tests
• 9918b6d: 8288609: Update --release 19 symbol information for JDK 19 build 28
• ... and 247 more: https://git.openjdk.org/jdk/compare/bde7a7ae03f51360227c9757b2ab3ddbff4df908...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jddarcy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rgiulietti]

/integrate

[openjdk]

@rgiulietti
Your change (at version 0efa530) is now ready to be sponsored by a Committer.

[jddarcy]

/sponsor

[openjdk]

Going to push as commit 354ed10.
Since your change was applied there have been 262 commits pushed to the master branch:

• f3f0788: 8288746: HttpClient resources could be reclaimed more eagerly
• be6be15: 8288750: IGV: Improve Shortcuts
• 210a06a: 8287227: Shenandoah: A couple of virtual thread tests failed with iu mode even without Loom enabled.
• 64f95cf: 8012675: javax.swing.JEditorPane is unclear on the handling of unsupported HTML script tags
• ddb55ed: 8135292: Remove duplicate code in Address.java in SA
• 7905788: 8289126: Cleanup unnecessary null comparison before instanceof check in jdk.hotspot.agent
• 47fe9ef: 8289078: Make STARTTIME_ANY and STARTTIME_PROCESS_UNKNOWN fields static in ProcessHandleImpl
• 62e1e79: 8289147: unify os::infinite_sleep on posix platforms
• de74671: 8266670: Better modeling of access flags in core reflection
• a5c25d8: 8286395: Address possibly lossy conversions in java.security.jgss
• ... and 252 more: https://git.openjdk.org/jdk/compare/bde7a7ae03f51360227c9757b2ab3ddbff4df908...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy @rgiulietti Pushed as commit 354ed10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.