4511638: Double.toString(double) sometimes produces incorrect results #3402

rgiulietti · 2021-04-08T21:12:21Z

Hello,

here's a PR for a patch submitted on March 2020 1 when Mercurial was a thing.

The patch has been edited to adhere to OpenJDK code conventions about multi-line (block) comments. Nothing in the code proper has changed, except for the addition of redundant but clarifying parentheses in some expressions.

Greetings
Raffaello

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires a CSR request to be approved

Issues

JDK-4511638: Double.toString(double) sometimes produces incorrect results
JDK-8202555: Double.toString(double) sometimes produces incorrect results (CSR)

Reviewers

Andrey Turbanov (@turbanoff - Committer) ⚠️ Review applies to c29dff76
@limck599 (no known github.com user name / role) ⚠️ Review applies to 907abfd6
Joe Darcy (@jddarcy - Reviewer)
Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3402/head:pull/3402
$ git checkout pull/3402

Update a local copy of the PR:
$ git checkout pull/3402
$ git pull https://git.openjdk.java.net/jdk pull/3402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3402

View PR using the GUI difftool:
$ git pr show -t 3402

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3402.diff

bridgekeeper · 2021-04-08T21:12:52Z

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

rgiulietti · 2021-04-08T21:20:34Z

Forgot to add that other changes in the code are the use of switch expressions and the use of instanceof patterns.

openjdk · 2021-04-08T21:24:31Z

@rgiulietti The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-08T21:27:58Z

Webrevs

rgiulietti · 2021-04-09T16:33:43Z

Hello,

here's some background information for those that didn't follow the mailing list for the last couple of years.

Some enjoyable properties of the novel algorithm:

No intermediate objects are instantiated.
Loop-free core algorithm.
Only int and long arithmetic.
No divisions at all.
17.7x speedup (jmh) 1.
Randomized, yet reproducible deep diving tests (jtreg).
Clear, unambiguous spec.
All floats have been tested to fully meet the spec.
Fully documented in 2 and/or in comments.

See 3 for some (invented) Q&A. The last Q&A deals with your investment in time for an informed review.

Greetings
Raffaello

bplb · 2021-04-09T16:39:45Z

@rgiulietti Please issue the /csr/ command here [1]. Speaking of which, does the CSR [2] need to be updated?

[1] https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/csr
[2] https://bugs.openjdk.java.net/browse/JDK-8202555

rgiulietti · 2021-04-09T16:42:42Z

/csr needed

openjdk · 2021-04-09T16:43:12Z

@rgiulietti this pull request will not be integrated until the CSR request JDK-8202555 for issue JDK-4511638 has been approved.

rgiulietti · 2021-04-09T16:44:18Z

@bplb No, the CSR [1] (https://bugs.openjdk.java.net/browse/JDK-8202555) needs no updates.

rgiulietti · 2021-04-09T16:47:34Z

The langtools/tier1 test tools/javac/sym/ElementStructureTest.java fails on all 4 platforms supported by the automatic GH actions.
Does anybody have a clue? Is this something I should be worried about?

Thanks

bplb · 2021-04-09T16:52:32Z

@bplb No, the CSR [1] (https://bugs.openjdk.java.net/browse/JDK-8202555) needs no updates.

OK, good. I wonder whether it should be moved back to Draft until someone else other than me has reviewed it?

lahodaj · 2021-04-15T17:23:44Z

Regarding the ElementStructureTest, it prints the API elements (including compile-time constants) computes hash for the printed API and compares it with an expected hash. doubles and floats are printed using String.valueOf, and it apparently changed for Float.MIN_NORMAL from 1.17549435E-38 to 1.1754944E-38 (I assume that is intentional). So regarding ElementStructureTest.java we can just update it. How about this?

diff --git a/test/langtools/tools/javac/sym/ElementStructureTest.java b/test/langtools/tools/javac/sym/ElementStructureTest.java
index 29776ce28c2..d15f2447749 100644
--- a/test/langtools/tools/javac/sym/ElementStructureTest.java
+++ b/test/langtools/tools/javac/sym/ElementStructureTest.java
@@ -121,29 +121,22 @@ import toolbox.ToolBox;
  */
 public class ElementStructureTest {
 
-    static final byte[] hash6 = new byte[] {
-        (byte) 0x99, (byte) 0x34, (byte) 0x82, (byte) 0xCF,
-        (byte) 0xE0, (byte) 0x53, (byte) 0xF3, (byte) 0x13,
-        (byte) 0x4E, (byte) 0xCF, (byte) 0x49, (byte) 0x32,
-        (byte) 0xB7, (byte) 0x52, (byte) 0x0F, (byte) 0x68
-    };
     static final byte[] hash7 = new byte[] {
-        (byte) 0x3C, (byte) 0x03, (byte) 0xEA, (byte) 0x4A,
-        (byte) 0x62, (byte) 0xD2, (byte) 0x18, (byte) 0xE5,
-        (byte) 0xA5, (byte) 0xC2, (byte) 0xB7, (byte) 0x85,
-        (byte) 0x90, (byte) 0xFA, (byte) 0x98, (byte) 0xCD
+        (byte) 0xA7, (byte) 0x3B, (byte) 0x91, (byte) 0xF6,
+        (byte) 0xEF, (byte) 0x99, (byte) 0x07, (byte) 0xF2,
+        (byte) 0x79, (byte) 0xAB, (byte) 0x19, (byte) 0xF4,
+        (byte) 0x59, (byte) 0x44, (byte) 0xF7, (byte) 0x65
     };
     static final byte[] hash8 = new byte[] {
-        (byte) 0x24, (byte) 0x38, (byte) 0x52, (byte) 0x1C,
-        (byte) 0x5E, (byte) 0x83, (byte) 0x82, (byte) 0xE6,
-        (byte) 0x41, (byte) 0xC2, (byte) 0xDD, (byte) 0x2A,
-        (byte) 0xFD, (byte) 0xFF, (byte) 0x5E, (byte) 0x2F
+        (byte) 0xF3, (byte) 0x93, (byte) 0xCA, (byte) 0x53,
+        (byte) 0xFD, (byte) 0xA3, (byte) 0x5D, (byte) 0x57,
+        (byte) 0xD2, (byte) 0xED, (byte) 0x39, (byte) 0xC5,
+        (byte) 0x56, (byte) 0x62, (byte) 0xE0, (byte) 0x1F
     };
 
     final static Map<String, byte[]> version2Hash = new HashMap<>();
 
     static {
-        version2Hash.put("6", hash6);
         version2Hash.put("7", hash7);
         version2Hash.put("8", hash8);
     }
@@ -484,7 +477,7 @@ public class ElementStructureTest {
                 return null;
             try {
                 analyzeElement(e);
-                out.write(String.valueOf(e.getConstantValue()));
+                writeConstant(e.getConstantValue());
                 out.write("\n");
             } catch (IOException ex) {
                 ex.printStackTrace();
@@ -514,6 +507,16 @@ public class ElementStructureTest {
             throw new IllegalStateException("Should not get here.");
         }
 
+        private void writeConstant(Object value) throws IOException {
+            if (value instanceof Double) {
+                out.write(Long.toString(Double.doubleToRawLongBits((Double) value)));
+            } else if (value instanceof Float) {
+                out.write(Integer.toString(Float.floatToRawIntBits((Float) value)));
+            } else {
+                out.write(String.valueOf(value));
+            }
+        }
+
     }
 
     final class TestFileManager implements JavaFileManager {

mlbridge · 2021-04-15T19:15:15Z

Mailing list message from Joe Darcy on core-libs-dev:

Hi Jan,

I recommend using {Double, Float}.toHexString to get a straightforward
textual form of the floating-point values. The hex string is isomorphic
to the big-level value, but is (more) human readable as a numerical
quantity.

-Joe

On 4/15/2021 10:26 AM, Jan Lahoda wrote:

rgiulietti · 2021-04-16T08:06:55Z

Hi Jan,

I had to change a string in test
test/jdk/java/lang/String/concat/ImplicitStringConcatBoundaries.java
because it failed with the current string but passes with the new one. Indeed, the new implementation of Float.toString(float) produces the new string, which, like the current one, is correct in the sense that, upon reading, it recovers Float.MIN_NORMAL.

However, I didn't change the definition of MIN_NORMAL in java.lang.Float because there it is already expressed in hex notation.

As suggested before and by Joe, using the hex representation instead of the decimal would be more robust because the conversions from/to hex are almost trivial, hence much less subject to slight errors. So, rather than printing the raw bits as you suggest, you could use the hex string rendering instead.

Thanks
Raffaello

lahodaj · 2021-04-16T08:11:31Z

Sure, here you are:

diff --git a/test/langtools/tools/javac/sym/ElementStructureTest.java b/test/langtools/tools/javac/sym/ElementStructureTest.java
index 29776ce28c2..428ba03361f 100644
--- a/test/langtools/tools/javac/sym/ElementStructureTest.java
+++ b/test/langtools/tools/javac/sym/ElementStructureTest.java
@@ -121,29 +121,22 @@ import toolbox.ToolBox;
  */
 public class ElementStructureTest {
 
-    static final byte[] hash6 = new byte[] {
-        (byte) 0x99, (byte) 0x34, (byte) 0x82, (byte) 0xCF,
-        (byte) 0xE0, (byte) 0x53, (byte) 0xF3, (byte) 0x13,
-        (byte) 0x4E, (byte) 0xCF, (byte) 0x49, (byte) 0x32,
-        (byte) 0xB7, (byte) 0x52, (byte) 0x0F, (byte) 0x68
-    };
     static final byte[] hash7 = new byte[] {
-        (byte) 0x3C, (byte) 0x03, (byte) 0xEA, (byte) 0x4A,
-        (byte) 0x62, (byte) 0xD2, (byte) 0x18, (byte) 0xE5,
-        (byte) 0xA5, (byte) 0xC2, (byte) 0xB7, (byte) 0x85,
-        (byte) 0x90, (byte) 0xFA, (byte) 0x98, (byte) 0xCD
+        (byte) 0x65, (byte) 0x41, (byte) 0xC8, (byte) 0x17,
+        (byte) 0xF0, (byte) 0xB1, (byte) 0x62, (byte) 0x9A,
+        (byte) 0xD8, (byte) 0x19, (byte) 0xBA, (byte) 0xB0,
+        (byte) 0xC1, (byte) 0x70, (byte) 0x5E, (byte) 0x3E
     };
     static final byte[] hash8 = new byte[] {
-        (byte) 0x24, (byte) 0x38, (byte) 0x52, (byte) 0x1C,
-        (byte) 0x5E, (byte) 0x83, (byte) 0x82, (byte) 0xE6,
-        (byte) 0x41, (byte) 0xC2, (byte) 0xDD, (byte) 0x2A,
-        (byte) 0xFD, (byte) 0xFF, (byte) 0x5E, (byte) 0x2F
+        (byte) 0x83, (byte) 0x62, (byte) 0x2F, (byte) 0x1C,
+        (byte) 0x95, (byte) 0x6D, (byte) 0x31, (byte) 0x18,
+        (byte) 0xF5, (byte) 0xB2, (byte) 0x8C, (byte) 0x39,
+        (byte) 0x81, (byte) 0x2E, (byte) 0x2C, (byte) 0x34
     };
 
     final static Map<String, byte[]> version2Hash = new HashMap<>();
 
     static {
-        version2Hash.put("6", hash6);
         version2Hash.put("7", hash7);
         version2Hash.put("8", hash8);
     }
@@ -484,7 +477,7 @@ public class ElementStructureTest {
                 return null;
             try {
                 analyzeElement(e);
-                out.write(String.valueOf(e.getConstantValue()));
+                writeConstant(e.getConstantValue());
                 out.write("\n");
             } catch (IOException ex) {
                 ex.printStackTrace();
@@ -514,6 +507,16 @@ public class ElementStructureTest {
             throw new IllegalStateException("Should not get here.");
         }
 
+        private void writeConstant(Object value) throws IOException {
+            if (value instanceof Double) {
+                out.write(Double.toHexString((Double) value));
+            } else if (value instanceof Float) {
+                out.write(Float.toHexString((Float) value));
+            } else {
+                out.write(String.valueOf(value));
+            }
+        }
+
     }
 
     final class TestFileManager implements JavaFileManager {

rgiulietti · 2021-04-16T08:19:17Z

Fine, thanks!

Will your change be integrated soon on master?
What am I supposed to do then, rebasing my branch with the updated master?

(BTW, you could make use of instanceof pattern matching if you don't need backward compat ;-) )

lahodaj · 2021-04-16T08:22:41Z

@ rgiulietti, I thought you'd simply add the test change to your patch. But I can start a PR for it, if you prefer.

rgiulietti · 2021-04-16T08:26:55Z

@lahodaj Oh, my understanding was that yours is a permanent change worth of integrating anyway. But yes, I can add your change to my changeset.

rgiulietti · 2021-04-16T11:26:59Z

Modified
test/langtools/tools/javac/sym/ElementStructureTest.java
as suggested by @lahodaj

turbanoff · 2021-04-18T18:53:24Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+    static final int Q_MAX = (1 << (W - 1)) - P;
+
+    /* 10^(E_MIN - 1) <= MIN_VALUE < 10^E_MIN */
+    static final int E_MIN = -323;


It seems that E_MIN/E_MAX/K_MIN/K_MAX are not used in production code.
I think it worth to move them to tests.

turbanoff · 2021-04-18T18:56:02Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+     *     -d.ddddddddddddddddE-eee    H + 7 characters
+     * where there are H digits d
+     */
+    public final int MAX_CHARS = H + 7;


Can it be made static ?

mlbridge · 2021-04-19T16:20:16Z

Mailing list message from Raffaello Giulietti on core-libs-dev:

Hi Andrey,

thanks for your careful reading.

I'll keep a note and collect yours with changes coming from other
reviewers before committing a larger batch of small changes. I would
like to avoid wasting a lot of energy right now just to rebuild
everything and to run the automatic tests on GitHub :-)

Greetings
Raffaello

On 2021-04-18 23:19, Andrey Turbanov wrote:

mlbridge · 2021-04-19T16:20:17Z

Mailing list message from Raffaello Giulietti on core-libs-dev:

Hi Andrey,

thanks for your careful reading.

I'll keep a note and collect yours with changes coming from other
reviewers before committing a larger batch of small changes. I would
like to avoid wasting a lot of energy right now just to rebuild
everything and to run the automatic tests on GitHub :-)

Greetings
Raffaello

On 2021-04-18 23:19, Andrey Turbanov wrote:

bridgekeeper · 2021-05-17T20:13:20Z

@rgiulietti This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

rgiulietti · 2021-05-25T16:52:29Z

Hi,

a reminder to keep PR [1] alive and to invite interested reviewers to
comment it.

The corresponding CSR is in [2]

Greetings
Raffaello

[1] #3402
[2] https://bugs.openjdk.java.net/browse/JDK-8202555

bplb · 2022-05-31T21:36:48Z

src/java.base/share/classes/jdk/internal/math/MathUtils.java

+     * The last entry must be for an exponent of K_MAX or more.
+     */
+    private static final long[] g = {
+        /* -324 */ 0x4F0C_EDC9_5A71_8DD4L, 0x5B01_E8B0_9AA0_D1B5L,


Not significant, but might this be clearer instead to comment the array elements on the right?

0x4F0C_EDC9_5A71_8DD4L, 0x5B01_E8B0_9AA0_D1B5L, // -324

bplb · 2022-05-31T21:52:30Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+     *
+     * [2] IEEE Computer Society, "IEEE Standard for Floating-Point Arithmetic"
+     *
+     * [3] Bouvier & Zimmermann, "Division-Free Binary-to-Decimal Conversion"


Similar comment concerning <cite/> tag as in MathUtils.

bplb · 2022-05-31T21:55:16Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+    /* Used for left-to-tight digit extraction */
+    private static final int MASK_28 = (1 << 28) - 1;
+
+    private static final int NON_SPECIAL    = 0;


Would these constants be better as an enum?

An enum would make much sense if it were used by other parts of the codebase, and then it would be moved to MathUtils.
This might well happen in the near future, when this code could be enhanced to be used in formatting conversions, like in "printf()" and friends.

bplb · 2022-05-31T21:57:44Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+    /* Index into bytes of rightmost valid character */
+    private int index;
+
+    private DoubleToDecimal() {


Maybe add a comment like

/** * Prevent instantiation. */

or

// Prevent instantiation of this class.

The constructor is invoked, so the comment would be inappropriate.

... but I added a throw in the constructor of MathUtils

bplb · 2022-05-31T22:10:37Z

src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java

+ */
+final public class FloatToDecimal {
+    /*
+     * For full details about this code see the following references:


Same comment about <cite/>.

bplb · 2022-05-31T22:11:54Z

src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java

+    /* Used for left-to-tight digit extraction */
+    private static final int MASK_28 = (1 << 28) - 1;
+
+    private static final int NON_SPECIAL    = 0;


As these are shared with DoubleToDecimal would these constants be better moved to a common location, e.g., MathUtils whether converted to an enum or not?

As long as the values are constant ints, moving them to MathUtils is less robust. Changing any value would require remembering to recompile the "clients".
The move would make sense if these were an enum.

bplb · 2022-05-31T22:12:14Z

src/java.base/share/classes/jdk/internal/math/FloatToDecimal.java

+    /* Index into bytes of rightmost valid character */
+    private int index;
+
+    private FloatToDecimal() {


Same comment about preventing instantiation.

bplb · 2022-05-31T22:27:42Z

src/java.base/share/classes/jdk/internal/math/DoubleToDecimal.java

+    /* 10^(E_MAX - 1) <= MAX_VALUE < 10^E_MAX */
+    static final int E_MAX = 309;
+
+    /* Threshold to detect tiny values, as in section 8.2.1 of [1] */


Comments like this one pointing to specific places in the Schubfach paper are very helpful in understanding the constants and the various steps in the algorithm.

bplb

I think it's time for this excellent work to advance.

openjdk · 2022-06-01T17:17:56Z

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4511638: Double.toString(double) sometimes produces incorrect results

Reviewed-by: aturbanov, darcy, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 381 new commits pushed to the master branch:

2f19144: 8282024: add EscapeAnalysis statistics under PrintOptoStatistics
cdb4768: 8287396: LIR_Opr::vreg_number() and data() can return negative number
4caf1ef: 8287390: Cleanup Map usage in AuthenticationInfo.requestAuthentication
27ad1d5: 8287602: (fs) Avoid redundant HashMap.containsKey call in MimeTypesFileTypeDetector.putIfAbsent
239ac2a: 8286829: Shenandoah: fix Shenandoah Loom support
67ecd30: 8287398: Allow concurrent execution of hotspot docker tests
8071b23: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux
774928f: 8287625: ProblemList jdk/jshell/HighlightUITest.java on all platforms
e3791ec: 8287491: compiler/jvmci/errors/TestInvalidDebugInfo.java fails new assert: assert((uint)t < T_CONFLICT + 1) failed: invalid type #
f8eb7a8: 8287512: continuationEntry.hpp has incomplete definitions
... and 371 more: https://git.openjdk.java.net/jdk/compare/d4474b5816c2ec8daaf1c905b77d8ba4e23c9439...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@turbanoff, @jddarcy, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

rgiulietti · 2022-06-01T21:49:20Z

/integrate

openjdk · 2022-06-01T21:51:18Z

@rgiulietti
Your change (at version 93711ba) is now ready to be sponsored by a Committer.

jddarcy · 2022-06-01T21:51:28Z

/sponsor

openjdk · 2022-06-01T21:54:09Z

Going to push as commit 72bcf2a.
Since your change was applied there have been 381 commits pushed to the master branch:

2f19144: 8282024: add EscapeAnalysis statistics under PrintOptoStatistics
cdb4768: 8287396: LIR_Opr::vreg_number() and data() can return negative number
4caf1ef: 8287390: Cleanup Map usage in AuthenticationInfo.requestAuthentication
27ad1d5: 8287602: (fs) Avoid redundant HashMap.containsKey call in MimeTypesFileTypeDetector.putIfAbsent
239ac2a: 8286829: Shenandoah: fix Shenandoah Loom support
67ecd30: 8287398: Allow concurrent execution of hotspot docker tests
8071b23: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux
774928f: 8287625: ProblemList jdk/jshell/HighlightUITest.java on all platforms
e3791ec: 8287491: compiler/jvmci/errors/TestInvalidDebugInfo.java fails new assert: assert((uint)t < T_CONFLICT + 1) failed: invalid type #
f8eb7a8: 8287512: continuationEntry.hpp has incomplete definitions
... and 371 more: https://git.openjdk.java.net/jdk/compare/d4474b5816c2ec8daaf1c905b77d8ba4e23c9439...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-06-01T21:54:30Z

@jddarcy @rgiulietti Pushed as commit 72bcf2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

adinn · 2022-06-06T12:01:41Z

Hallelujah!

LifeIsStrange · 2022-06-07T16:31:48Z

@rgiulietti friendly ping, noob question: Do you believe some parts of the algorithm could exploit explicit SIMD instructions (via the high level Vector API) for even better performance (such as https://github.com/wrandelshofer/FastDoubleParser ) ?

4511638: Double.toString(double) sometimes produces incorrect results

cc10a92

openjdk bot added the rfr Pull request is ready for review label Apr 8, 2021

openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 8, 2021

openjdk bot added the csr Pull request needs approved CSR before integration label Apr 9, 2021

4511638: Double.toString(double) sometimes produces incorrect results

22092f0

turbanoff reviewed Apr 18, 2021

View reviewed changes

Changed MAX_CHARS to static

24bae6a

bplb reviewed May 31, 2022

View reviewed changes

4511638: Double.toString(double) sometimes produces incorrect results

93711ba

bplb approved these changes Jun 1, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2022

jddarcy approved these changes Jun 1, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 1, 2022

openjdk bot added the integrated Pull request has been integrated label Jun 1, 2022

openjdk bot closed this Jun 1, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 1, 2022

re-thc mentioned this pull request Jun 7, 2022

Allow use of faster floating-point number parsing (Schubfach) with StreamReadFeature.USE_FAST_DOUBLE_PARSER FasterXML/jackson-core#577

Closed

rgiulietti mentioned this pull request Jun 14, 2022

8288021: Add hard test cases to jdk.internal.math.DoubleToDecimalChecker #9084

Closed

3 tasks

zimmermann6 mentioned this pull request Jan 3, 2023

Increase the precision used for string_of_float ocaml/ocaml#11360

Closed

rgiulietti deleted the JDK-4511638 branch April 4, 2023 15:33

4511638: Double.toString(double) sometimes produces incorrect results #3402

4511638: Double.toString(double) sometimes produces incorrect results #3402

Uh oh!

Conversation

rgiulietti commented Apr 8, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 8, 2021

Uh oh!

rgiulietti commented Apr 8, 2021

Uh oh!

openjdk bot commented Apr 8, 2021

Uh oh!

mlbridge bot commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

rgiulietti commented Apr 9, 2021

Uh oh!

bplb commented Apr 9, 2021

Uh oh!

rgiulietti commented Apr 9, 2021

Uh oh!

openjdk bot commented Apr 9, 2021

Uh oh!

rgiulietti commented Apr 9, 2021

Uh oh!

rgiulietti commented Apr 9, 2021

Uh oh!

bplb commented Apr 9, 2021

Uh oh!

lahodaj commented Apr 15, 2021

Uh oh!

mlbridge bot commented Apr 15, 2021

Uh oh!

rgiulietti commented Apr 16, 2021

Uh oh!

lahodaj commented Apr 16, 2021

Uh oh!

rgiulietti commented Apr 16, 2021

Uh oh!

lahodaj commented Apr 16, 2021

Uh oh!

rgiulietti commented Apr 16, 2021

Uh oh!

rgiulietti commented Apr 16, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Apr 19, 2021

Uh oh!

mlbridge bot commented Apr 19, 2021

Uh oh!

bridgekeeper bot commented May 17, 2021

Uh oh!

rgiulietti commented May 25, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

rgiulietti commented Apr 8, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 8, 2021 •

edited

Loading

openjdk bot commented Jun 1, 2022 •

edited

Loading