8379344: Compact the Unicode/CLDR version tables#30099
8379344: Compact the Unicode/CLDR version tables#30099naotoj wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
justin-curtis-lu
left a comment
There was a problem hiding this comment.
The new tables look great. I think the JBS issue should be updated to say that the five-most recent releases are shown, rather than the LTS releases.
Thanks. I forgot to update the JBS entry, as picking LTSes does not seem to be appropriate from the Java SE spec standpoint. |
|
I recommend you add a HTML comment that the non-collapsable table should show 5 entries. Otherwise the rule for hiding entries is confusing and the list may still explode over time. |
Minor Javadoc fix to
java.lang.Characterandjava.util.spi.LocaleServiceProvider, which list supported Unicode/CLDR versions. Since the tables grow with each JDK release, older releases should be coalesced.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30099/head:pull/30099$ git checkout pull/30099Update a local copy of the PR:
$ git checkout pull/30099$ git pull https://git.openjdk.org/jdk.git pull/30099/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30099View PR using the GUI difftool:
$ git pr show -t 30099Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30099.diff
Using Webrev
Link to Webrev Comment