Skip to content

8379363: FontInfo improvements#30098

Open
gredler wants to merge 1 commit intoopenjdk:masterfrom
gredler:JDK-8379363
Open

8379363: FontInfo improvements#30098
gredler wants to merge 1 commit intoopenjdk:masterfrom
gredler:JDK-8379363

Conversation

@gredler
Copy link
Contributor

@gredler gredler commented Mar 5, 2026

FontInfo contains a few small items which could use fixing:

  • toString() throws NPE if devTx or glyphTx are null (I ran into this a couple of times during debugging when my IDE tried to display the string representation)

  • toString() is missing a comma and space between the last two attributes

  • Two overridden methods do not have the @Override annotation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30098/head:pull/30098
$ git checkout pull/30098

Update a local copy of the PR:
$ git checkout pull/30098
$ git pull https://git.openjdk.org/jdk.git pull/30098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30098

View PR using the GUI difftool:
$ git pr show -t 30098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30098.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2026

👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2026

@gredler This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379363: FontInfo improvements

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3363a16: 8375045: Incorrect Interpretation of POSIX TZ Environment Variable on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 5, 2026
@openjdk
Copy link

openjdk bot commented Mar 5, 2026

@gredler The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2026

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants