Conversation
|
👋 Welcome back dgredler! A progress list of the required criteria for merging this PR into |
|
@gredler This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
FontInfo contains a few small items which could use fixing:
toString() throws NPE if
devTxorglyphTxare null (I ran into this a couple of times during debugging when my IDE tried to display the string representation)toString() is missing a comma and space between the last two attributes
Two overridden methods do not have the
@OverrideannotationProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30098/head:pull/30098$ git checkout pull/30098Update a local copy of the PR:
$ git checkout pull/30098$ git pull https://git.openjdk.org/jdk.git pull/30098/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30098View PR using the GUI difftool:
$ git pr show -t 30098Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30098.diff
Using Webrev
Link to Webrev Comment