Skip to content

8379233: [REDO] Remove some unused code in generateOopMap.cpp#30095

Open
coleenp wants to merge 3 commits intoopenjdk:masterfrom
coleenp:oopmap-cleanup
Open

8379233: [REDO] Remove some unused code in generateOopMap.cpp#30095
coleenp wants to merge 3 commits intoopenjdk:masterfrom
coleenp:oopmap-cleanup

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Mar 5, 2026

This redoes removing unused code in generateOopMap.cpp without removing the two methods that were actually used. _init_vars are used but not in fill_init_vars.

Tested with tier1-4, and tier1 locally.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379233: [REDO] Remove some unused code in generateOopMap.cpp (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30095/head:pull/30095
$ git checkout pull/30095

Update a local copy of the PR:
$ git checkout pull/30095
$ git pull https://git.openjdk.org/jdk.git pull/30095/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30095

View PR using the GUI difftool:
$ git pr show -t 30095

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30095.diff

Using Webrev

Link to Webrev Comment

@coleenp coleenp marked this pull request as ready for review March 5, 2026 19:31
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2026

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 5, 2026
@openjdk
Copy link

openjdk bot commented Mar 5, 2026

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant