8379326: Use JUnit in lib-test/jdk tests, here MethodTemplateTest

[sormuras]

Please review this change to use JUnit API in MethodTemplateTest.java. As only simple assertTrue and assertFalse are being called in test code, a swap of packages in import statements suffices.

This pull request also disallows testng actions in jtreg under this test root to prevent future additions of TestNG-based tests. See the umbrella issue https://bugs.openjdk.org/browse/JDK-8307843 and its associated subtasks for details.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8379326: Use JUnit in lib-test/jdk tests, here MethodTemplateTest (Sub-task - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30087/head:pull/30087
$ git checkout pull/30087

Update a local copy of the PR:
$ git checkout pull/30087
$ git pull https://git.openjdk.org/jdk.git pull/30087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30087

View PR using the GUI difftool:
$ git pr show -t 30087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30087.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379326: Use JUnit in lib-test/jdk tests, here MethodTemplateTest

Reviewed-by: dfuchs, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 4d9d2c3: 8284315: DocTrees.getElement is inconsistent with Elements.getTypeElement
• 0668dab: 8379114: HttpServer path prefix matching incorrectly matches paths that are not slash-prefixed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6b2c0cf9)

[dfuch]

I am not a typical Reviewer for that area, so maybe wait for someone who's worked on this codebase before to approve, before integrating. That said, having already converted a few TestNG tests to JUnit myself, I had a look at your proposed changes and they looked good. I verified that there was not assertEquals that would have required swapping the parameter order, and therefore no need to replace assertEquals with assertArrayEquals anywhere either.
So LGTM.

[RogerRiggs]

Looks good

[sormuras]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit a2ad080.
Since your change was applied there have been 14 commits pushed to the master branch:

• 310d5a1: 8346256: Optimize UMIN/UMAX reduction operations for x86 targets
• e640664: 8378758: [VectorAPI] Add Jtreg scalar operation wrappers for math operators and APIs
• a1b4ad0: 8379345: jpackage: Fix issues in tests to improve their flexibility
• ... and 11 more: https://git.openjdk.org/jdk/compare/dfea6eb9f84142aaa3e51181ea345e8575729ea2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras Pushed as commit a2ad080.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.