8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux by alexeysemenyukoracle · Pull Request #30085 · openjdk/jdk

alexeysemenyukoracle · 2026-03-05T15:17:27Z

Fix jpackage to use the correct arch for DEB bundles when running on RPM-based Linux, and vice versa.

The bug was in jdk.jpackage.internal.LinuxBundlingEnvironment class.

Additionally:

Add missing single quote escape to error.unexpected-default-package-property.advice l10n string
Reworded error.unexpected-package-property l10n string
JPackageStringBundle: add cannedFormattedStringAsPattern(); throw when the number of format arguments doesn't match the number of format fields; add unit tests; ErrorTest, InstallDirTest: follow-up bugfixes
LinuxHelper: fix unexpected java.lang.AssertionError: Failed: Check [libc] package is in the list of required packages [/bin/sh, /bin/sh, /bin/sh, rpmlib(CompressedFileNames) <= 3.0.4-1, rpmlib(PayloadFilesHavePrefix) <= 4.0-1] of [simplepackagetest] package error when bundling RPM package on Ubuntu; Make getDefaultPackageArch() thread-safe

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Warning

⚠️ Found leading lowercase letter in issue title for 8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux

Issue

JDK-8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux (Bug - P4)

Reviewers

Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30085/head:pull/30085
$ git checkout pull/30085

Update a local copy of the PR:
$ git checkout pull/30085
$ git pull https://git.openjdk.org/jdk.git pull/30085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30085

View PR using the GUI difftool:
$ git pr show -t 30085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30085.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-03-05T15:19:53Z

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-03-05T15:20:16Z

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

1a4825b: 8379158: Update FreeType to 2.14.2
c2f6bd8: 8379334: jpackage: fix bug in DottedVersion.greedy() function
f266079: 8378917: InputEvent checks for SystemClipboard access are unused
... and 41 more: https://git.openjdk.org/jdk/compare/284d1310d059764b5fb887d4693af623c2f7e89a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-03-05T15:20:57Z

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

…thread-safe; JPackageCommand: add fullVersion() and improve version(); don't validate dependencies of alien (non-native) packages; Fix "java.lang.AssertionError: Failed: Check [libc] package is in the list of required packages [/bin/sh, /bin/sh, /bin/sh, rpmlib(CompressedFileNames) <= 3.0.4-1, rpmlib(PayloadFilesHavePrefix) <= 4.0-1] of [simplepackagetest] package" error when bundling RPM package on Ubuntu

…n the number of format arguments doesn't match the number of format fields; add unit tests; ErrorTest: follow-up bugfix

… system where both RPM and DEB packaging is enabled.

… "error.unexpected-package-property"; Add missing single quote escape to the "error.unexpected-default-package-property.advice" message

alexeysemenyukoracle · 2026-03-05T23:30:31Z

@sashamatveev PTAL

mlbridge · 2026-03-05T23:38:57Z

Webrevs

01: Full - Incremental (ebc42da1)
00: Full (09fcc996)

…doesn't contain the "wrong Linux package architecture" error

openjdk · 2026-03-05T23:41:27Z

@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

sashamatveev · 2026-03-06T01:58:46Z

src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties

+error.unexpected-package-property=Expected value of "{0}" property is [{1}]. Actual value in output package is [{2}]. Looks like the value of "{0}" property is hardcoded in "{3}" file in the resource directory
 error.unexpected-package-property.advice=Use [{0}] pattern string instead of hard coded value [{1}] of {2} property in custom "{3}" file
-error.unexpected-default-package-property.advice=Don't explicitly set value of {0} property in custom "{1}" file
+error.unexpected-default-package-property.advice=Don''t explicitly set value of "{0}" property in custom "{1}" file


Why two '' in Don''t?

Because the first quote escapes the second one. See https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/text/MessageFormat.html#quoting-rules-in-patterns-heading.

Without quoting, the format string is printed as Dont explicitly set value of {0} property in custom "{1}" file and format arguments are ignored. Note how Don't turns into Dont and formatting elements ({0}, and {1}) printed as is without being replaced by the arguments.

sashamatveev

Looks good.

alexeysemenyukoracle · 2026-03-06T03:32:23Z

/integrate

openjdk · 2026-03-06T03:33:20Z

Going to push as commit c532dff.
Since your change was applied there have been 44 commits pushed to the master branch:

1a4825b: 8379158: Update FreeType to 2.14.2
c2f6bd8: 8379334: jpackage: fix bug in DottedVersion.greedy() function
f266079: 8378917: InputEvent checks for SystemClipboard access are unused
... and 41 more: https://git.openjdk.org/jdk/compare/284d1310d059764b5fb887d4693af623c2f7e89a...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-06T03:33:37Z

@alexeysemenyukoracle Pushed as commit c532dff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 5, 2026

alexeysemenyukoracle changed the title ~~LinuxBundlingEnvironment: fix jpackage correctly pick package arch on…~~ 8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux Mar 5, 2026

alexeysemenyukoracle force-pushed the fix-rpm+deb-bundling branch from 7509b6d to 944715b Compare March 5, 2026 22:17

alexeysemenyukoracle added 5 commits March 5, 2026 18:29

JPackageStringBundle: add cannedFormattedStringAsPattern(); throw whe…

107ade7

…n the number of format arguments doesn't match the number of format fields; add unit tests; ErrorTest: follow-up bugfix

InstallDirTest: bugfix revealed by tightening up JPackageStringBundle

0eea6d8

LinuxBundlingEnvironment: fix jpackage correctly pick package arch on…

c1c844f

… system where both RPM and DEB packaging is enabled.

PackageProperty: bugfix & refactor; LinuxResources.properties: reword…

3412128

… "error.unexpected-package-property"; Add missing single quote escape to the "error.unexpected-default-package-property.advice" message

alexeysemenyukoracle force-pushed the fix-rpm+deb-bundling branch from 83d0068 to 09fcc99 Compare March 5, 2026 23:29

alexeysemenyukoracle marked this pull request as ready for review March 5, 2026 23:30

openjdk bot added the rfr Pull request is ready for review label Mar 5, 2026

alexeysemenyukoracle added 2 commits March 5, 2026 18:39

JPackageCommand: add standard assert to check that jpackage's output …

de109eb

…doesn't contain the "wrong Linux package architecture" error

Update copyright year

ebc42da

alexeysemenyukoracle force-pushed the fix-rpm+deb-bundling branch from 09fcc99 to ebc42da Compare March 5, 2026 23:39

sashamatveev reviewed Mar 6, 2026

View reviewed changes

sashamatveev approved these changes Mar 6, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2026

openjdk bot added the integrated Pull request has been integrated label Mar 6, 2026

openjdk bot closed this Mar 6, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux#30085

8379348: jpackage will use wrong arch suffix for RPM bundle when running on Debian Linux#30085
alexeysemenyukoracle wants to merge 7 commits intoopenjdk:masterfrom
alexeysemenyukoracle:fix-rpm+deb-bundling

alexeysemenyukoracle commented Mar 5, 2026 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Mar 5, 2026

Uh oh!

openjdk bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

openjdk bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

alexeysemenyukoracle commented Mar 5, 2026

Uh oh!

mlbridge bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

openjdk bot commented Mar 5, 2026

Uh oh!

sashamatveev Mar 6, 2026

Uh oh!

alexeysemenyukoracle Mar 6, 2026

Uh oh!

sashamatveev left a comment

Uh oh!

alexeysemenyukoracle commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

alexeysemenyukoracle commented Mar 5, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warning

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Mar 5, 2026

Uh oh!

openjdk bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeysemenyukoracle commented Mar 5, 2026

Uh oh!

mlbridge bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Mar 5, 2026

Uh oh!

sashamatveev Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

sashamatveev left a comment

Choose a reason for hiding this comment

Uh oh!

alexeysemenyukoracle commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026

Uh oh!

openjdk bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

alexeysemenyukoracle commented Mar 5, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Mar 5, 2026 •

edited

Loading

openjdk bot commented Mar 5, 2026 •

edited

Loading

mlbridge bot commented Mar 5, 2026 •

edited

Loading