Skip to content

Improve canned formatted string#30084

Draft
alexeysemenyukoracle wants to merge 2 commits intoopenjdk:masterfrom
alexeysemenyukoracle:improve-CannedFormattedString
Draft

Improve canned formatted string#30084
alexeysemenyukoracle wants to merge 2 commits intoopenjdk:masterfrom
alexeysemenyukoracle:improve-CannedFormattedString

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Mar 5, 2026


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ The pull request body must not be empty.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30084/head:pull/30084
$ git checkout pull/30084

Update a local copy of the PR:
$ git checkout pull/30084
$ git pull https://git.openjdk.org/jdk.git pull/30084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30084

View PR using the GUI difftool:
$ git pr show -t 30084

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30084.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2026

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 5, 2026
@openjdk
Copy link

openjdk bot commented Mar 5, 2026

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

…[] to List<Object> and fix addPrefix() to make the default CannedFormattedString#equals() work correctly; add unit tests; JPackageStringBundle: use the same fomatter to make CannedFormattedString#equals() work correctly
@alexeysemenyukoracle alexeysemenyukoracle force-pushed the improve-CannedFormattedString branch from d336e22 to 3bad2e6 Compare March 6, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant