8357944: Remove unused CollectedHeap::is_maximal_no_gc

[albertnetymk]

Removing effectively dead code/API for all GCs except G1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357944: Remove unused CollectedHeap::is_maximal_no_gc (Enhancement - P4)

Reviewers

• Joel Sikström (@jsikstro - Committer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25482/head:pull/25482
$ git checkout pull/25482

Update a local copy of the PR:
$ git checkout pull/25482
$ git pull https://git.openjdk.org/jdk.git pull/25482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25482

View PR using the GUI difftool:
$ git pr show -t 25482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25482.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357944: Remove unused CollectedHeap::is_maximal_no_gc

Reviewed-by: jsikstro, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• c5a1543: 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent
• 90d6ad0: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog()
• 3193a28: 8358259: ProblemList compiler/startup/StartupOutput.java on Windows
• ... and 89 more: https://git.openjdk.org/jdk/compare/db515566875b92bd4aff08cccc80d80b85f01514...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (700acb84)

[jsikstro]

Looks good. This code is quite old, but I wonder if it's also appropriate to rename is_maximal_no_gc() to something more descriptive, maybe is_expandable() and reverse the check, which I think looks better at the callers of is_maximal_no_gc(). Not sure if that should be done separately or not though, and I don't have strong opinions on G1 code.

[albertnetymk]

I wonder if it's also appropriate to rename is_maximal_no_gc() to something more descriptive ...

I agree the current name is not very nice. I am leaned towards changing its return-type also: uint num_inactive_regions() const { return _hrm.num_inactive_regions(); }. However, I feel that discussion can get its own ticket.

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 6418306.
Since your change was applied there have been 93 commits pushed to the master branch:

• 3f59bfd: 8334759: gc/g1/TestMixedGCLiveThreshold.java fails on Windows with JTREG_TEST_THREAD_FACTORY=Virtual due to extra memory allocation
• c5a1543: 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent
• 90d6ad0: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog()
• ... and 90 more: https://git.openjdk.org/jdk/compare/db515566875b92bd4aff08cccc80d80b85f01514...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 6418306.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.