Fix: Address vulnerability in getDocumentBuilder() #24643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a XXE vulnerability in getDocumentBuilder(). The PR disable external entity processing and enables secure processing by setting the XMLConstants.FEATURE_SECURE_PROCESSING feature.
Something similar can be found here soartech/jsoar@ae6a2ec
References
soartech/jsoar@ae6a2ec
https://nvd.nist.gov/vuln/detail/CVE-2023-34610
Progress
Error
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24643/head:pull/24643
$ git checkout pull/24643
Update a local copy of the PR:
$ git checkout pull/24643
$ git pull https://git.openjdk.org/jdk.git pull/24643/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24643
View PR using the GUI difftool:
$ git pr show -t 24643
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24643.diff