8354447: Missing test for retroactive @SuppressWarnings("dangling-doc-comments") behavior

[archiecobbs]

This PR adds a regression test for the "retroactive" behavior of @SuppressWarnings("dangling-doc-comments"), that is, the warning suppression applies to comments preceding the declaration that the annotation annotates, even though those comments are not within the lexical scope of that declaration. Previously there was no test for this behavior.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354447: Missing test for retroactive @SuppressWarnings("dangling-doc-comments") behavior (Enhancement - P5)

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24600/head:pull/24600
$ git checkout pull/24600

Update a local copy of the PR:
$ git checkout pull/24600
$ git pull https://git.openjdk.org/jdk.git pull/24600/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24600

View PR using the GUI difftool:
$ git pr show -t 24600

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24600.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354447: Missing test for retroactive @SuppressWarnings("dangling-doc-comments") behavior

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1085 new commits pushed to the master branch:

• b3f5608: 8358094: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java still times out after JDK-8357282
• ee35f63: 8359373: Split stubgen initial blob into pre and post-universe blobs
• 12a0dd0: 8358738: AOT cache created without graal jit should not be used with graal jit
• ... and 1082 more: https://git.openjdk.org/jdk/compare/1d7138fe021d64686ac59cddd1bc7c787c610aa9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e67b47be)

[bridgekeeper]

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[archiecobbs]

/touch

[openjdk]

@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@archiecobbs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[archiecobbs]

/touch

[openjdk]

@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset.

[archiecobbs]

Now that JDK 25 has been split off, are there any reviewers available to review this simple change? Thanks in advance.

[archiecobbs]

/touch

[openjdk]

@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset.

[archiecobbs]

Thanks for the review!

[archiecobbs]

/integrate

[openjdk]

Going to push as commit 0e725c6.
Since your change was applied there have been 1085 commits pushed to the master branch:

• b3f5608: 8358094: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java still times out after JDK-8357282
• ee35f63: 8359373: Split stubgen initial blob into pre and post-universe blobs
• 12a0dd0: 8358738: AOT cache created without graal jit should not be used with graal jit
• ... and 1082 more: https://git.openjdk.org/jdk/compare/1d7138fe021d64686ac59cddd1bc7c787c610aa9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@archiecobbs Pushed as commit 0e725c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.