Try to resolve path of LLD when using Clang #23248
Conversation
To allow users override LLD variable and specify an alternative linker, such as mold, who are also capable to link and produce a working OpenJDK. Signed-off-by: Bingwu Zhang <xtex@aosc.io>
|
Hi @xtexChooser, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user xtexChooser" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
@xtexChooser The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
/signed |
|
Already processed the |
|
The OCA can take a ludicrously long time to process, hang tight. In my case it took more than a month |
|
@xtexx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
activation. OCA submission is still under review (: |
|
@xtexx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
ping |
|
@xtexx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
/signed |
|
Already processed the |
|
@xtexx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@xtexx The pull request is being re-evaluated and the inactivity timeout has been reset. |
To allow users override LLD variable and specify an alternative linker, such as mold, who are also capable to link and produce a working OpenJDK.
As mentioned in the mail list: https://mail.openjdk.org/pipermail/build-dev/2025-January/048618.html , I submitted this as a PR.
Not sure if we need to change it to use a --with option.
Note that I have signed off an individual OCA, but it has been "Under Review" for more than two days.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23248/head:pull/23248$ git checkout pull/23248Update a local copy of the PR:
$ git checkout pull/23248$ git pull https://git.openjdk.org/jdk.git pull/23248/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23248View PR using the GUI difftool:
$ git pr show -t 23248Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23248.diff