8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output

[tzezula]

The compiler/jvmci/TestJVMCISavedProperties test fails due to overlapping output from the saved system properties. The initialization of savedProperties in jdk.vm.ci.services.Services is correctly synchronized, the issue suggests that two separate libjvmci compiler isolates are each printing their own set of saved properties.

In a successful test run, the CompileBroker thread aborts the VM before it completes initialization, displaying the error message Cannot use JVMCI compiler: Value of jvmci.Compiler is “null” (due to the -Djvmci.Compiler=null setting), and the message DONE IN MAIN is never printed. However, in the failed test output, the DONE IN MAIN message appears, indicating that the VM initialization completed and created the JVMCIRuntime instance. The CompileBroker thread might have concurrently initialized JVMCIRuntime in another isolate. Since each JVMCIRuntime initialization outputs system properties, this is likely the cause of the overlapping output.

The proposed solution is to use the -XX:+EnableJVMCI flag instead of -XX:+UseJVMCICompiler, to avoid this issue.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output (Bug - P4)

Reviewers

• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21583/head:pull/21583
$ git checkout pull/21583

Update a local copy of the PR:
$ git checkout pull/21583
$ git pull https://git.openjdk.org/jdk.git pull/21583/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21583

View PR using the GUI difftool:
$ git pr show -t 21583

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21583.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tzezula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tzezula This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 309b929: 8336401: Remove the option onjcmd from the jdwp agent
• 401d0d6: 8335662: [AArch64] C1: guarantee(val < (1ULL << nbits)) failed: Field too big for insn
• 8591109: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning
• 0784011: 8340488: Clarify LocaleServiceProvider deployment on application module path
• 4dcc7f3: 8337536: AArch64: Enable BTI branch protection for runtime part

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@tzezula The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7849ba67)
• 00: Full (306efecb)

[dougxc]

Looks good to me - thanks for fixing it.

[openjdk]

@tzezula Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[dougxc]

Still looks fine.

[openjdk]

⚠️ @tzezula the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8342295
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[tzezula]

/integrate

[openjdk]

@tzezula
Your change (at version 7849ba6) is now ready to be sponsored by a Committer.

[dougxc]

/sponsor

[openjdk]

Going to push as commit 330f2b5.
Since your change was applied there have been 17 commits pushed to the master branch:

• 1f35748: 8342102: ZGC: Optimize copy constructors in ZPhysicalMemory
• 66ddaaa: 8340241: RISC-V: Returns mispredicted
• 07f550b: 8340818: Add a new jtreg test root to test the generated documentation
• 27ef6c9: 8341470: BigDecimal.stripTrailingZeros() optimization
• 5d5d88a: 8339570: Add Tidy build support for JDK tests
• 239d84a: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• aa060f2: 8342334: CDS: Scratch mirrors should not point to dead klasses
• 680dc5d: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress
• 8f2b23b: 8341407: C2: assert(main_limit == cl->limit() || get_ctrl(main_limit) == new_limit_ctrl) failed: wrong control for added limit
• 21682bc: 8342612: Increase memory usage of compiler/c2/TestScalarReplacementMaxLiveNodes.java
• ... and 7 more: https://git.openjdk.org/jdk/compare/28252bb48da3c960a1a261af26650d74235a9531...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc @tzezula Pushed as commit 330f2b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.