-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output #21583
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back tzezula! A progress list of the required criteria for merging this PR into |
@tzezula This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks for fixing it.
@tzezula Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks fine.
|
/integrate |
The
compiler/jvmci/TestJVMCISavedProperties
test fails due to overlapping output from the saved system properties. The initialization ofsavedProperties
injdk.vm.ci.services.Services
is correctly synchronized, the issue suggests that two separate libjvmci compiler isolates are each printing their own set of saved properties.In a successful test run, the
CompileBroker
thread aborts the VM before it completes initialization, displaying the error messageCannot use JVMCI compiler: Value of jvmci.Compiler is “null”
(due to the-Djvmci.Compiler=null
setting), and the messageDONE IN MAIN
is never printed. However, in the failed test output, theDONE IN MAIN
message appears, indicating that the VM initialization completed and created theJVMCIRuntime
instance. TheCompileBroker
thread might have concurrently initializedJVMCIRuntime
in another isolate. Since eachJVMCIRuntime
initialization outputs system properties, this is likely the cause of the overlapping output.The proposed solution is to use the
-XX:+EnableJVMCI
flag instead of-XX:+UseJVMCICompiler
, to avoid this issue.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21583/head:pull/21583
$ git checkout pull/21583
Update a local copy of the PR:
$ git checkout pull/21583
$ git pull https://git.openjdk.org/jdk.git pull/21583/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21583
View PR using the GUI difftool:
$ git pr show -t 21583
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21583.diff
Webrev
Link to Webrev Comment