8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)

[CptGit]

Hello,

(~a) | (~b) => ~(a & b) is a widely seen pattern, for example it is implemented for LLVM here; however it is missing in current implementation of hotspot. This pull request adds this transformation and associated tests.

Thanks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b) (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to dc60a548
• Emanuel Peter (@eme64 - Reviewer) ⚠️ Review applies to b21e242b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16334/head:pull/16334
$ git checkout pull/16334

Update a local copy of the PR:
$ git checkout pull/16334
$ git pull https://git.openjdk.org/jdk.git pull/16334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16334

View PR using the GUI difftool:
$ git pr show -t 16334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16334.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back CptGit! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@CptGit The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@CptGit This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[CptGit]

Hi, can I get a review?

[TobiHartmann]

A JBS issue has been created for this: JDK-8322077. Please update the PR accordingly.

[mlbridge]

Webrevs

• 12: Full (f908668b)
• 11: Full - Incremental (dc60a548)
• 10: Full - Incremental (b21e242b)
• 09: Full - Incremental (0c8d1077)
• 08: Full - Incremental (6eb29aef)
• 07: Full - Incremental (d8ed0f35)
• 06: Full (15a38bda)
• 05: Full - Incremental (f7e57ce4)
• 04: Full - Incremental (154c69e5)
• 03: Full - Incremental (8697e399)
• 02: Full - Incremental (6d291ae1)
• 01: Full - Incremental (341f869c)
• 00: Full (2e64889e)

[CptGit]

A JBS issue has been created for this: JDK-8322077. Please update the PR accordingly.

Thanks. Updated.

[merykitty]

LGTM, but may you consider having dedicated functions to check and create Not patterns? Thanks a lot.

[CptGit]

LGTM, but may you consider having dedicated functions to check and create Not patterns? Thanks a lot.

Thanks. I updated. Please let me know if there are more comments.

[TobiHartmann]

Looks good to me. Please update the copyright dates.

I submitted testing and will report back once it passed.

[eme64]

Looks like a good idea. Left a few comments.

I would have merged this with #16333, since it is essentially the symmetric case. But leave it separate now.

It would be nice to have some shared tests, where both optimizations need to be combined. Like:
(~a | ~b) & (~c | ~d) -> ~(a & b) & ~(c & d) -> ~((a & b) | (c & d))

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout ornode-PNewDeMorganLawOrToAnd
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@CptGit This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322077: Add Ideal transformation: (~a) | (~b) => ~(a & b)

Reviewed-by: thartmann, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• c5e7245: 8322735: C2: minor improvements of bubble sort used in SuperWord::packset_sort
• 65a0672: 8319773: Avoid inflating monitors when installing hash codes for LM_LIGHTWEIGHT
• e22ab10: 8322537: Parallel: Remove experimental adjustment in PSAdaptiveSizePolicy
• be900f1: 8323425: JFR: Auto-generated filename doesn't work with time-limited recording
• 68c4286: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 7dc9dd6: 8234502: Merge GenCollectedHeap and SerialHeap
• ed18222: 8323190: Segfault during deoptimization of C2-compiled code
• 3e19bf8: 8323529: Relativize test image dependencies in microbenchmarks
• ba23025: 8322957: Generational ZGC: Relocation selection must join the STS
• 7c3a39f: 8323297: Fix incorrect placement of precompiled.hpp include lines
• ... and 31 more: https://git.openjdk.org/jdk/compare/b86c3b7a68335d57699ea3c5ec6d09a62ea9026a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @eme64) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

⚠️ @CptGit This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[eme64]

@CptGit can you merge from master again, please? It looks now like you are pushing both the changes here and the ones from your previous PR. Once you did that, I'd like to run some testing before we push this.

[CptGit]

@eme64 Yes I merged. Looks clean now.

[eme64]

Testing running for commit 34...

[TobiHartmann]

All tests passed, this is good to go.

[CptGit]

/integrate

[openjdk]

@CptGit
Your change (at version f908668) is now ready to be sponsored by a Committer.

[CptGit]

@eme64 @TobiHartmann Thanks for testing! Can you sponsor it when you get a chance thank you!

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 1515bd7.
Since your change was applied there have been 53 commits pushed to the master branch:

• bdee968: 4760025: sRGB conversions to and from CIE XYZ incorrect
• 71d9a83: 8323243: JNI invocation of an abstract instance method corrupts the stack
• d83ea92: 8301466: [AIX] Revisit CommittedVirtualMemoryTest
• 5cf7947: 8323562: SaslInputStream.read() may return wrong value
• dc7d3b1: 8321489: Update LCMS to 2.16
• 84cf4cb: 8318563: GetClassFields should not use random access to field
• 9e9c05f: 8322979: Add informative discussion to Modifier
• c54bca6: 8323617: Add missing null checks to GetMousePositionWithPopup.java test
• 95a9168: 8323627: Shenandoah: Refactor init logger
• 999e556: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
• ... and 43 more: https://git.openjdk.org/jdk/compare/b86c3b7a68335d57699ea3c5ec6d09a62ea9026a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @CptGit Pushed as commit 1515bd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.