8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)

[CptGit]

Hello,

(~a) & (~b) => ~(a | b) is a widely seen pattern, for example it is implemented for LLVM here; however it is missing in current implementation of hotspot. This pull request adds this transformation and associated tests.

Thanks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b) (Enhancement - P4)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Emanuel Peter (@eme64 - Reviewer) ⚠️ Review applies to 4ee8b089

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/16333/head:pull/16333
$ git checkout pull/16333

Update a local copy of the PR:
$ git checkout pull/16333
$ git pull https://git.openjdk.org/jdk.git pull/16333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16333

View PR using the GUI difftool:
$ git pr show -t 16333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/16333.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back CptGit! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@CptGit The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@CptGit This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[CptGit]

Hi, can I get a review?

[jaikiran]

Hi, can I get a review?

Hello @CptGit, can you create an enhancement request here https://bugreport.java.com/bugreport/? Someone with knowledge of this area will then be able to decide if it's a valid enhancement, in which case there will be a corresponding JDK issue created against which you can then link this PR for review.

[CptGit]

Hi, can I get a review?

Hello @CptGit, can you create an enhancement request here https://bugreport.java.com/bugreport/? Someone with knowledge of this area will then be able to decide if it's a valid enhancement, in which case there will be a corresponding JDK issue created against which you can then link this PR for review.

Thanks for the comment. I have created a bug report.

[mlbridge]

Webrevs

• 10: Full - Incremental (65942221)
• 09: Full - Incremental (4ee8b089)
• 08: Full - Incremental (3665de2f)
• 07: Full - Incremental (7a962d69)
• 06: Full - Incremental (c4fa2e40)
• 05: Full - Incremental (afa0737a)
• 04: Full - Incremental (ecb2098b)
• 03: Full - Incremental (6ee5f182)
• 02: Full - Incremental (3b95720a)
• 01: Full - Incremental (5072eb14)
• 00: Full (cf2edb46)

[TobiHartmann]

I think dedicated methods like you used in #16334 would be good. Please also update the copyright dates.

[eme64]

Looks like a good idea :)
I left a few suggestions below.

[CptGit]

@eme64 @TobiHartmann Thanks for the comments. All addressed.

[TobiHartmann]

Looks good to me otherwise.

/reviewers 2

[openjdk]

@CptGit This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322589: Add Ideal transformation: (~a) & (~b) => ~(a | b)

Reviewed-by: thartmann, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 887 new commits pushed to the master branch:

• f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
• 376051a: 8320919: Clarify Locale related system properties
• a5071e0: 8322817: RISC-V: Eliminate -Wparentheses warnings in riscv code
• 28d8149: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE
• e9f7db3: 8322880: Eliminate -Wparentheses warnings in arm32 code
• aba1933: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
• f3be138: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
• bc05893: 8323318: Remove unused Space::is_free_block
• dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
• ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
• ... and 877 more: https://git.openjdk.org/jdk/compare/eb5916729defd37002f4096d4910849938e0fe3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @eme64) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@TobiHartmann
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[eme64]

LGTM, thanks for the work! 😊

[CptGit]

/integrate

[openjdk]

@CptGit
Your change (at version 6594222) is now ready to be sponsored by a Committer.

[CptGit]

@TobiHartmann @eme64 Thanks a lot for reviewing and all the comments. Can you sponsor when you get a chance?

[TobiHartmann]

Thanks, looks good.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 8569227.
Since your change was applied there have been 887 commits pushed to the master branch:

• f4ca41a: 8322816: RISC-V: Incorrect guarantee in patch_vtype
• 376051a: 8320919: Clarify Locale related system properties
• a5071e0: 8322817: RISC-V: Eliminate -Wparentheses warnings in riscv code
• 28d8149: 8323115: x86-32: Incorrect predicates for cmov instruct transforms with UseSSE
• e9f7db3: 8322880: Eliminate -Wparentheses warnings in arm32 code
• aba1933: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
• f3be138: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
• bc05893: 8323318: Remove unused Space::is_free_block
• dd8ae61: 8322237: Heap dump contains duplicate thread records for mounted virtual threads
• ee98d26: 8323066: gc/g1/TestSkipRebuildRemsetPhase.java fails with 'Skipping Remembered Set Rebuild.' missing
• ... and 877 more: https://git.openjdk.org/jdk/compare/eb5916729defd37002f4096d4910849938e0fe3b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @CptGit Pushed as commit 8569227.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.