modification per code review suggestions

Author: tabjy

src/hotspot/share/opto/subnode.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -1813,16 +1813,16 @@ Node *BoolNode::Ideal(PhaseGVN *phase, bool can_reshape) {
 // Simplify a Bool (convert condition codes to boolean (1 or 0)) node,
 // based on local information.   If the input is constant, do it.
 const Type* BoolNode::Value(PhaseGVN* phase) const {
-  Node *cmp = in(1);
-  if (cmp && cmp->is_Sub()) {
+  Node* cmp = in(1);
+  if (cmp != nullptr && cmp->is_Sub()) {
     int cop = cmp->Opcode();
-    Node *cmp1 = cmp->in(1);
-    Node *cmp2 = cmp->in(2);
+    Node* cmp1 = cmp->in(1);
+    Node* cmp2 = cmp->in(2);
 
     // Change ((x & m) u<= m) or ((m & x) u<= m) to always true
     // Same with ((x & m) u< m+1) and ((m & x) u< m+1)
     if (cop == Op_CmpU && cmp1->Opcode() == Op_AndI) {
-      Node *bound = nullptr;
+      Node* bound = nullptr;
       if (_test._test == BoolTest::le) {
         bound = cmp2;
       } else if (_test._test == BoolTest::lt && cmp2->Opcode() == Op_AddI && cmp2->in(2)->find_int_con(0) == 1) {

test/hotspot/jtreg/compiler/c2/TestBoolNodeGvn.java renamed to test/hotspot/jtreg/compiler/c2/irTests/TestBoolNodeGvn.java

@@ -33,7 +33,8 @@
 
 /**
  * @test
- * @summary
+ * @bug 8327381
+ * @summary Refactor boolean node tautology transformations
  * @library /test/lib /
  * @run driver compiler.c2.TestBoolNodeGvn
  */