Skip to content

Commit 7c82e09

Browse files
committed
8357048: RunTest variables should always be assigned
Reviewed-by: erikj
1 parent 5f38d1b commit 7c82e09

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

make/RunTests.gmk

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,8 @@ define SetMicroValue
583583
else
584584
ifneq ($3, )
585585
$1_$2 := $3
586+
else
587+
$1_$2 :=
586588
endif
587589
endif
588590
endef
@@ -709,6 +711,8 @@ define SetJtregValue
709711
else
710712
ifneq ($3, )
711713
$1_$2 := $3
714+
else
715+
$1_$2 :=
712716
endif
713717
endif
714718
endif
@@ -869,7 +873,7 @@ define SetupRunJtregTestBody
869873
# version of the JDK.
870874
$1_JTREG_BASIC_OPTIONS += -$$($1_JTREG_TEST_MODE) \
871875
-verbose:$$(JTREG_VERBOSE) -retain:$$(JTREG_RETAIN) \
872-
-concurrency:$$($1_JTREG_JOBS) -timeoutFactor:$$(JTREG_TIMEOUT_FACTOR) \
876+
-concurrency:$$($1_JTREG_JOBS) \
873877
-vmoption:-XX:MaxRAMPercentage=$$($1_JTREG_MAX_RAM_PERCENTAGE) \
874878
-vmoption:-Dtest.boot.jdk="$$(BOOT_JDK)" \
875879
-vmoption:-Djava.io.tmpdir="$$($1_TEST_TMP_DIR)"
@@ -994,6 +998,7 @@ define SetupRunJtregTestBody
994998
endif
995999

9961000
JTREG_TIMEOUT_FACTOR ?= $$(JTREG_AUTO_TIMEOUT_FACTOR)
1001+
$1_JTREG_BASIC_OPTIONS += -timeoutFactor:$$(JTREG_TIMEOUT_FACTOR)
9971002

9981003
clean-outputdirs-$1:
9991004
$$(call LogWarn, Clean up dirs for $1)

0 commit comments

Comments
 (0)