Skip to content

Commit 55cc0af

Browse files
linadeshipilev
authored andcommitted
8266185: Shenandoah: Fix incorrect comment/assertion messages
Reviewed-by: shade
1 parent 880c138 commit 55cc0af

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ void ShenandoahBarrierSetC2::satb_write_barrier_pre(GraphKit* kit,
247247
// if (!marking)
248248
__ if_then(marking, BoolTest::ne, zero, unlikely); {
249249
BasicType index_bt = TypeX_X->basic_type();
250-
assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading G1 SATBMarkQueue::_index with wrong size.");
250+
assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading Shenandoah SATBMarkQueue::_index with wrong size.");
251251
Node* index = __ load(__ ctrl(), index_adr, TypeX_X, index_bt, Compile::AliasIdxRaw);
252252

253253
if (do_load) {
@@ -360,7 +360,7 @@ void ShenandoahBarrierSetC2::shenandoah_write_barrier_pre(GraphKit* kit,
360360
// Helper that guards and inserts a pre-barrier.
361361
void ShenandoahBarrierSetC2::insert_pre_barrier(GraphKit* kit, Node* base_oop, Node* offset,
362362
Node* pre_val, bool need_mem_bar) const {
363-
// We could be accessing the referent field of a reference object. If so, when G1
363+
// We could be accessing the referent field of a reference object. If so, when Shenandoah
364364
// is enabled, we need to log the value in the referent field in an SATB buffer.
365365
// This routine performs some compile time filters and generates suitable
366366
// runtime filters that guard the pre-barrier code.
@@ -978,7 +978,7 @@ void ShenandoahBarrierSetC2::verify_gc_barriers(Compile* compile, CompilePhase p
978978
if (ShenandoahVerifyOptoBarriers && phase == BarrierSetC2::BeforeMacroExpand) {
979979
ShenandoahBarrierC2Support::verify(Compile::current()->root());
980980
} else if (phase == BarrierSetC2::BeforeCodeGen) {
981-
// Verify G1 pre-barriers
981+
// Verify Shenandoah pre-barriers
982982
const int marking_offset = in_bytes(ShenandoahThreadLocalData::satb_mark_queue_active_offset());
983983

984984
Unique_Node_List visited;
@@ -1174,7 +1174,7 @@ bool ShenandoahBarrierSetC2::escape_add_to_con_graph(ConnectionGraph* conn_graph
11741174
case Op_StoreP: {
11751175
Node* adr = n->in(MemNode::Address);
11761176
const Type* adr_type = gvn->type(adr);
1177-
// Pointer stores in G1 barriers looks like unsafe access.
1177+
// Pointer stores in Shenandoah barriers looks like unsafe access.
11781178
// Ignore such stores to be able scalar replace non-escaping
11791179
// allocations.
11801180
if (adr_type->isa_rawptr() && adr->is_AddP()) {

src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1531,7 +1531,7 @@ void ShenandoahBarrierC2Support::pin_and_expand(PhaseIdealLoop* phase) {
15311531
phase->register_new_node(index_adr, ctrl);
15321532

15331533
BasicType index_bt = TypeX_X->basic_type();
1534-
assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading G1 SATBMarkQueue::_index with wrong size.");
1534+
assert(sizeof(size_t) == type2aelembytes(index_bt), "Loading Shenandoah SATBMarkQueue::_index with wrong size.");
15351535
const TypePtr* adr_type = TypeRawPtr::BOTTOM;
15361536
Node* index = new LoadXNode(ctrl, raw_mem, index_adr, adr_type, TypeX_X, MemNode::unordered);
15371537
phase->register_new_node(index, ctrl);

0 commit comments

Comments
 (0)