Skip to content

Commit 527a309

Browse files
committed
8252722: More Swing plaf APIs that rely on default constructors
Reviewed-by: prr
1 parent 3495c19 commit 527a309

36 files changed

+468
-4
lines changed

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicBorders.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@
4747

4848
public class BasicBorders {
4949

50+
/**
51+
* Constructs a {@code BasicBorders}.
52+
*/
53+
public BasicBorders() {}
54+
5055
/**
5156
* Returns a border instance for a {@code JButton}.
5257
*
@@ -473,6 +478,11 @@ public Insets getBorderInsets(Component c, Insets insets) {
473478
*/
474479
@SuppressWarnings("serial") // Superclass is not serializable across versions
475480
public static class MarginBorder extends AbstractBorder implements UIResource {
481+
/**
482+
* Constructs a {@code MarginBorder}.
483+
*/
484+
public MarginBorder() {}
485+
476486
public Insets getBorderInsets(Component c, Insets insets) {
477487
Insets margin = null;
478488
//

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicButtonUI.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ public class BasicButtonUI extends ButtonUI{
7676
// ********************************
7777
// Create PLAF
7878
// ********************************
79+
/**
80+
* Constructs a {@code BasicButtonUI}.
81+
*/
82+
public BasicButtonUI() {}
83+
7984
/**
8085
* Returns an instance of {@code BasicButtonUI}.
8186
*

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicCheckBoxMenuItemUI.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,11 @@
3939
*/
4040
public class BasicCheckBoxMenuItemUI extends BasicMenuItemUI {
4141

42+
/**
43+
* Constructs a {@code BasicCheckBoxMenuItemUI}.
44+
*/
45+
public BasicCheckBoxMenuItemUI() {}
46+
4247
/**
4348
* Constructs a new instance of {@code BasicCheckBoxMenuItemUI}.
4449
*

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicCheckBoxUI.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,11 @@ public class BasicCheckBoxUI extends BasicRadioButtonUI {
6060
// Create PLAF
6161
// ********************************
6262

63+
/**
64+
* Constructs a {@code BasicCheckBoxUI}.
65+
*/
66+
public BasicCheckBoxUI() {}
67+
6368
/**
6469
* Returns an instance of {@code BasicCheckBoxUI}.
6570
*

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicColorChooserUI.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ public class BasicColorChooserUI extends ColorChooserUI
7777
protected PropertyChangeListener propertyChangeListener;
7878
private Handler handler;
7979

80+
/**
81+
* Constructs a {@code BasicColorChooserUI}.
82+
*/
83+
public BasicColorChooserUI() {}
84+
8085
/**
8186
* Returns a new instance of {@code BasicColorChooserUI}.
8287
*
@@ -383,6 +388,11 @@ else if (prop == "componentOrientation") {
383388
* Instantiate it only within subclasses of {@code BasicColorChooserUI}.
384389
*/
385390
public class PropertyHandler implements PropertyChangeListener {
391+
/**
392+
* Constructs a {@code PropertyHandler}.
393+
*/
394+
public PropertyHandler() {}
395+
386396
public void propertyChange(PropertyChangeEvent e) {
387397
getHandler().propertyChange(e);
388398
}

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,5 +176,9 @@ public void setBorder(Border b) {
176176
@SuppressWarnings("serial") // Same-version serialization only
177177
public static class UIResource extends BasicComboBoxEditor
178178
implements javax.swing.plaf.UIResource {
179+
/**
180+
* Constructs a {@code UIResource}.
181+
*/
182+
public UIResource() {}
179183
}
180184
}

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxRenderer.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,5 +145,9 @@ public Component getListCellRendererComponent(JList<?> list,
145145
*/
146146
@SuppressWarnings("serial") // Same-version serialization only
147147
public static class UIResource extends BasicComboBoxRenderer implements javax.swing.plaf.UIResource {
148+
/**
149+
* Constructs a {@code UIResource}.
150+
*/
151+
public UIResource() {}
148152
}
149153
}

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,11 @@ public class BasicComboBoxUI extends ComboBoxUI {
232232
*/
233233
protected Insets padding;
234234

235+
/**
236+
* Constructs a {@code BasicComboBoxUI}.
237+
*/
238+
public BasicComboBoxUI() {}
239+
235240
// Used for calculating the default size.
236241
private static ListCellRenderer<Object> getDefaultListCellRenderer() {
237242
@SuppressWarnings("unchecked")
@@ -592,6 +597,11 @@ private Handler getHandler() {
592597
* <code>BasicComboBoxUI</code>.
593598
*/
594599
public class KeyHandler extends KeyAdapter {
600+
/**
601+
* Constructs a {@code KeyHandler}.
602+
*/
603+
public KeyHandler() {}
604+
595605
@Override
596606
public void keyPressed( KeyEvent e ) {
597607
getHandler().keyPressed(e);
@@ -607,6 +617,11 @@ public void keyPressed( KeyEvent e ) {
607617
* <code>BasicComboBoxUI</code>.
608618
*/
609619
public class FocusHandler implements FocusListener {
620+
/**
621+
* Constructs a {@code FocusHandler}.
622+
*/
623+
public FocusHandler() {}
624+
610625
public void focusGained( FocusEvent e ) {
611626
getHandler().focusGained(e);
612627
}
@@ -627,6 +642,11 @@ public void focusLost( FocusEvent e ) {
627642
* @see #createListDataListener
628643
*/
629644
public class ListDataHandler implements ListDataListener {
645+
/**
646+
* Constructs a {@code ListDataHandler}.
647+
*/
648+
public ListDataHandler() {}
649+
630650
public void contentsChanged( ListDataEvent e ) {
631651
getHandler().contentsChanged(e);
632652
}
@@ -651,6 +671,11 @@ public void intervalRemoved( ListDataEvent e ) {
651671
* @see #createItemListener
652672
*/
653673
public class ItemHandler implements ItemListener {
674+
/**
675+
* Constructs a {@code ItemHandler}.
676+
*/
677+
public ItemHandler() {}
678+
654679
// This class used to implement behavior which is now redundant.
655680
public void itemStateChanged(ItemEvent e) {}
656681
}
@@ -670,6 +695,11 @@ public void itemStateChanged(ItemEvent e) {}
670695
* @see #createPropertyChangeListener
671696
*/
672697
public class PropertyChangeHandler implements PropertyChangeListener {
698+
/**
699+
* Constructs a {@code PropertyChangeHandler}.
700+
*/
701+
public PropertyChangeHandler() {}
702+
673703
public void propertyChange(PropertyChangeEvent e) {
674704
getHandler().propertyChange(e);
675705
}
@@ -697,6 +727,11 @@ private void updateToolTipTextForChildren() {
697727
* <code>BasicComboBoxUI</code>.
698728
*/
699729
public class ComboBoxLayoutManager implements LayoutManager {
730+
/**
731+
* Constructs a {@code ComboBoxLayoutManager}.
732+
*/
733+
public ComboBoxLayoutManager() {}
734+
700735
public void addLayoutComponent(String name, Component comp) {}
701736

702737
public void removeLayoutComponent(Component comp) {}

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboPopup.java

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -733,6 +733,11 @@ public void actionPerformed(ActionEvent e){
733733
* @see BasicComboPopup#createMouseListener
734734
*/
735735
protected class InvocationMouseHandler extends MouseAdapter {
736+
/**
737+
* Constructs an {@code InvocationMouseHandler}.
738+
*/
739+
protected InvocationMouseHandler() {}
740+
736741
/**
737742
* Responds to mouse-pressed events on the combo box.
738743
*
@@ -758,6 +763,11 @@ public void mouseReleased( MouseEvent e ) {
758763
* list if it is dragging over the list.
759764
*/
760765
protected class InvocationMouseMotionHandler extends MouseMotionAdapter {
766+
/**
767+
* Constructs an {@code InvocationMouseMotionHandler}.
768+
*/
769+
protected InvocationMouseMotionHandler() {}
770+
761771
public void mouseDragged( MouseEvent e ) {
762772
getHandler().mouseDragged(e);
763773
}
@@ -771,6 +781,10 @@ public void mouseDragged( MouseEvent e ) {
771781
* BasicComboBoxUI ActionMap/InputMap methods.
772782
*/
773783
public class InvocationKeyHandler extends KeyAdapter {
784+
/**
785+
* Constructs an {@code InvocationKeyHandler}.
786+
*/
787+
public InvocationKeyHandler() {}
774788
public void keyReleased( KeyEvent e ) {}
775789
}
776790

@@ -780,6 +794,10 @@ public void keyReleased( KeyEvent e ) {}
780794
* override.
781795
*/
782796
protected class ListSelectionHandler implements ListSelectionListener {
797+
/**
798+
* Constructs a {@code ListSelectionHandler}.
799+
*/
800+
protected ListSelectionHandler() {}
783801
public void valueChanged( ListSelectionEvent e ) {}
784802
}
785803

@@ -793,6 +811,10 @@ public void valueChanged( ListSelectionEvent e ) {}
793811
* @see #createItemListener
794812
*/
795813
public class ListDataHandler implements ListDataListener {
814+
/**
815+
* Constructs a {@code ListDataHandler}.
816+
*/
817+
public ListDataHandler() {}
796818
public void contentsChanged( ListDataEvent e ) {}
797819

798820
public void intervalAdded( ListDataEvent e ) {
@@ -806,6 +828,10 @@ public void intervalRemoved( ListDataEvent e ) {
806828
* This listener hides the popup when the mouse is released in the list.
807829
*/
808830
protected class ListMouseHandler extends MouseAdapter {
831+
/**
832+
* Constructs a {@code ListMouseHandler}.
833+
*/
834+
protected ListMouseHandler() {}
809835
public void mousePressed( MouseEvent e ) {
810836
}
811837
public void mouseReleased(MouseEvent anEvent) {
@@ -818,6 +844,11 @@ public void mouseReleased(MouseEvent anEvent) {
818844
* The selection change is not committed to the model, this is for user feedback only.
819845
*/
820846
protected class ListMouseMotionHandler extends MouseMotionAdapter {
847+
/**
848+
* Constructs a {@code ListMouseMotionHandler}.
849+
*/
850+
protected ListMouseMotionHandler() {}
851+
821852
public void mouseMoved( MouseEvent anEvent ) {
822853
getHandler().mouseMoved(anEvent);
823854
}
@@ -828,6 +859,10 @@ public void mouseMoved( MouseEvent anEvent ) {
828859
* combo box.
829860
*/
830861
protected class ItemHandler implements ItemListener {
862+
/**
863+
* Constructs an {@code ItemHandler}.
864+
*/
865+
protected ItemHandler() {}
831866
public void itemStateChanged( ItemEvent e ) {
832867
getHandler().itemStateChanged(e);
833868
}
@@ -844,6 +879,10 @@ public void itemStateChanged( ItemEvent e ) {
844879
* @see #createPropertyChangeListener
845880
*/
846881
protected class PropertyChangeHandler implements PropertyChangeListener {
882+
/**
883+
* Constructs a {@code PropertyChangeHandler}.
884+
*/
885+
protected PropertyChangeHandler() {}
847886
public void propertyChange( PropertyChangeEvent e ) {
848887
getHandler().propertyChange(e);
849888
}

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDesktopIconUI.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,11 @@ public class MouseInputHandler extends MouseInputAdapter
243243
int __x, __y;
244244
Rectangle startingBounds;
245245

246+
/**
247+
* Constructs a {@code MouseInputHandler}.
248+
*/
249+
public MouseInputHandler() {}
250+
246251
public void mouseReleased(MouseEvent e) {
247252
_x = 0;
248253
_y = 0;

0 commit comments

Comments
 (0)