Skip to content

Commit 4fb1980

Browse files
committed
8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
Reviewed-by: shade
1 parent 73ba3ae commit 4fb1980

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -302,16 +302,9 @@ void ShenandoahBarrierSetAssembler::load_reference_barrier_native(MacroAssembler
302302

303303
void ShenandoahBarrierSetAssembler::storeval_barrier(MacroAssembler* masm, Register dst, Register tmp) {
304304
if (ShenandoahStoreValEnqueueBarrier) {
305-
// Save possibly live regs.
306-
RegSet live_regs = RegSet::range(r0, r4) - dst;
307-
__ push(live_regs, sp);
308-
__ strd(v0, __ pre(sp, 2 * -wordSize));
309-
305+
__ push_call_clobbered_registers();
310306
satb_write_barrier_pre(masm, noreg, dst, rthread, tmp, true, false);
311-
312-
// Restore possibly live regs.
313-
__ ldrd(v0, __ post(sp, 2 * wordSize));
314-
__ pop(live_regs, sp);
307+
__ pop_call_clobbered_registers();
315308
}
316309
}
317310

test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2017, 2018, Red Hat, Inc. All rights reserved.
2+
* Copyright (c) 2017, 2020, Red Hat, Inc. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -69,6 +69,11 @@
6969
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
7070
* -XX:+ShenandoahVerify -XX:+IgnoreUnrecognizedVMOptions -XX:+ShenandoahVerifyOptoBarriers
7171
* TestVerifyJCStress
72+
*
73+
* @run main/othervm -Xmx1g -Xms1g -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions
74+
* -XX:+UseShenandoahGC -XX:ShenandoahGCMode=iu
75+
* -XX:+ShenandoahVerify -XX:+IgnoreUnrecognizedVMOptions -XX:TieredStopAtLevel=1
76+
* TestVerifyJCStress
7277
*/
7378

7479
import java.util.*;

0 commit comments

Comments
 (0)