Skip to content

Commit 394ce5f

Browse files
sormurasLance Andersen
authored andcommitted
8280825: Modules that "provide" ToolProvider should document the name that can be used
Reviewed-by: jjg, lancea, alanb
1 parent 745f7e7 commit 394ce5f

File tree

6 files changed

+27
-5
lines changed

6 files changed

+27
-5
lines changed

src/jdk.compiler/share/classes/module-info.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2014, 2021, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -62,6 +62,9 @@
6262
* @toolGuide javac
6363
*
6464
* @provides java.util.spi.ToolProvider
65+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("javac")}
66+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
67+
* of command-line access to the {@code javac} tool.
6568
* @provides com.sun.tools.javac.platform.PlatformProvider
6669
* @provides javax.tools.JavaCompiler
6770
* @provides javax.tools.Tool

src/jdk.jartool/share/classes/module-info.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -39,6 +39,11 @@
3939
* @toolGuide jar
4040
* @toolGuide jarsigner
4141
*
42+
* @provides java.util.spi.ToolProvider
43+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("jar")}
44+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
45+
* of command-line access to the {@code jar} tool.
46+
*
4247
* @moduleGraph
4348
* @since 9
4449
*/

src/jdk.javadoc/share/classes/module-info.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -45,6 +45,9 @@
4545
* @toolGuide javadoc
4646
*
4747
* @provides java.util.spi.ToolProvider
48+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("javadoc")}
49+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
50+
* of command-line access to the {@code javadoc} tool.
4851
* @provides javax.tools.DocumentationTool
4952
* @provides javax.tools.Tool
5053
*

src/jdk.jdeps/share/classes/module-info.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@
4949
* @toolGuide jdeps
5050
*
5151
* @provides java.util.spi.ToolProvider
52+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("javap")}
53+
* or {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("jdeps")}
54+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
55+
* of command-line access to the {@code javap} or {@code jdeps} tool.
5256
*
5357
* @moduleGraph
5458
* @since 9

src/jdk.jlink/share/classes/module-info.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -44,6 +44,9 @@
4444
* @toolGuide jmod
4545
*
4646
* @provides java.util.spi.ToolProvider
47+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("jlink")}
48+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
49+
* of command-line access to the {@code jlink} tool.
4750
*
4851
* @moduleGraph
4952
* @since 9

src/jdk.jpackage/share/classes/module-info.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -41,6 +41,10 @@
4141
* concurrently, even with separate {@code "jpackage"} {@code ToolProvider}
4242
* instances, or undefined behavior may result.
4343
*
44+
* @provides java.util.spi.ToolProvider
45+
* Use {@link java.util.spi.ToolProvider#findFirst ToolProvider.findFirst("jpackage")}
46+
* to obtain an instance of a {@code ToolProvider} that provides the equivalent
47+
* of command-line access to the {@code jpackage} tool.
4448
*
4549
* @moduleGraph
4650
* @since 16

0 commit comments

Comments
 (0)