Skip to content

Commit 0889155

Browse files
author
Ludvig Janiuk
committed
8332885: Clarify failure_handler self-tests
Reviewed-by: lmesnik
1 parent 7f0ad51 commit 0889155

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

make/test/BuildFailureHandler.gmk

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@ IMAGES_TARGETS += $(COPY_FH)
8181
# Use JTREG_TEST_OPTS for test VM options
8282
# Use JTREG_TESTS for jtreg tests parameter
8383
#
84+
# Most likely you want to select a specific test from test/failure_handler/test
85+
# and manually inspect the results. This target does not actually verify
86+
# anything about the failure_handler's output or even if it ran at all.
87+
#
8488
RUN_DIR := $(FH_SUPPORT)/test
8589

8690
test:

test/failure_handler/README

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,3 +102,15 @@ $ ${JTREG_HOME}/bin/jtreg -jdk:${JAVA_HOME} \
102102
-timeoutHandler:jdk.test.failurehandler.jtreg.GatherProcessInfoTimeoutHandler\
103103
-observer:jdk.test.failurehandler.jtreg.GatherDiagnosticInfoObserver \
104104
${WS}/hotspot/test/
105+
106+
TESTING
107+
108+
There are a few make targets for testing the failure_handler itself.
109+
- Everything in `test/failure_handler/Makefile`
110+
- The `test-failure-handler` target in `make/RunTests.gmk`
111+
- The `test` target in `make/test/BuildFailureHandler.gmk`
112+
All of these targets are written for manual testing only. They rely on
113+
manual inspection of generated artifacts and cannot be run as part of a CI.
114+
They are tests which timeout, crash, fail in various ways and you can check
115+
the failure_handler output yourself. They might also leave processes running
116+
on your machine so be extra careful about cleaning up.

0 commit comments

Comments
 (0)