8333725: Compiler Prototyping for Deconstructors by biboudis · Pull Request #94 · openjdk/amber

biboudis · 2024-05-13T14:10:31Z

Work-in-progress prototyping of deconstructors.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Warnings

⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor16.gif)
⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor32.gif)
⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono16.gif)
⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono32.gif)
⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/doc-files/JRootPane-1.gif)
⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/keystore)
⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/truststore)
⚠️ Patch contains a binary file (test/jdk/jdk/internal/loader/URLClassPath/testclasses.jar)
⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/dnsstore)
⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/ipstore)

Issue

JDK-8333725: Compiler Prototyping for Deconstructors (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/amber.git pull/94/head:pull/94
$ git checkout pull/94

Update a local copy of the PR:
$ git checkout pull/94
$ git pull https://git.openjdk.org/amber.git pull/94/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 94

View PR using the GUI difftool:
$ git pr show -t 94

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/amber/pull/94.diff

bridgekeeper · 2024-05-13T14:11:17Z

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-05-13T14:11:29Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2024-05-13T14:12:11Z

@biboudis this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout matchers-experiment
git fetch https://git.openjdk.org/amber.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk · 2024-05-13T14:23:28Z

⚠️ @biboudis This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

vicente-romero-oracle · 2024-06-01T00:18:38Z

        matchBindings = new MatchBindings(outBindings.toList(), List.nil());
    }

+    // todo: follow the protocol in Resolve::selectBest


this method I think belongs in Resolve

vicente-romero-oracle · 2024-06-01T00:23:48Z


+        if (tree.sym.isPattern()) {
+            tree.sym.flags_field  |= STATIC;
+            tree.sym.flags_field  |= SYNTHETIC;


we are making synthetic an AST that actually appears in the source?

vicente-romero-oracle · 2024-06-04T15:20:30Z

+                expectedRecordTypes = record.getRecordComponents()
+                                            .stream()
+                                            .map(rc -> types.memberType(site, rc))
+                                            .map(t -> types.upward(t, types.captures(t)).baseType())


not sure why the upward projection is used here

vicente-romero-oracle · 2024-06-06T21:04:11Z

     */
    int putNameAndType(Symbol s) {
-        return pool.writeIfNeeded(new NameAndType(s.name, descriptorType(s)));
+        return pool.writeIfNeeded(new NameAndType(s instanceof MethodSymbol ms ? ms.externalName(types) : s.name, descriptorType(s)));


same not sure why you need this change

Co-authored-by: Angelos Bimpoudis <angelos.bimpoudis@oracle.com> Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com> Co-authored-by: Vicente Romero <vicente.romero@oracle.com>

…o matchers-experiment # Conflicts: # src/java.base/share/classes/java/lang/Class.java

…pattern-parsing

Fixing a crash when javac is highlighting a deconstructor

Carriers update for matchers-experiment

…pattern-parsing

…nce-pattern-parsing' into matchers-experiment-instance-pattern-parsing

…hers-experiment-instance-pattern-parsing-overloading

…pattern-parsing

…ern-parsing An attempt to parse instance patterns more correctly.

…pattern-parsing-overloading # Conflicts: # src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

bridgekeeper · 2025-07-17T04:32:35Z

@biboudis This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Rick-24 · 2025-07-17T04:33:08Z

Hi @Rick-24, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK [Terms of Use](https://openjdk.java.net/legal/tou/). If you already are an OpenJDK [Author](https://openjdk.java.net/bylaws#author), [Committer](https://openjdk.java.net/bylaws#committer) or [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) to open a new issue so that we can record that fact. Please Use "Add GitHub user Rick-24" for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.  - [ ] I agree to the [OpenJDK Terms of Use](https://openjdk.java.net/legal/tou/) for all comments I make in a project in the [OpenJDK GitHub organization](https://github.com/openjdk).  Your comment will be automatically restored once you have accepted the OpenJDK [Terms of Use](https://openjdk.java.net/legal/tou/).

…tern-parsing-overloading Adjusting overloading + translation

…eriment

openjdk Bot added the merge-conflict The pull request has a merge conflict with the target branch label May 13, 2024

biboudis marked this pull request as draft May 13, 2024 14:20

openjdk Bot removed the merge-conflict The pull request has a merge conflict with the target branch label May 13, 2024

biboudis force-pushed the matchers-experiment branch from d635684 to ccc44d4 Compare May 27, 2024 11:24

vicente-romero-oracle reviewed Jun 1, 2024

View reviewed changes

Comment thread src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java Outdated

vicente-romero-oracle reviewed Jun 1, 2024

View reviewed changes

Comment thread test/test/Point.class Outdated

openjdk Bot added the merge-conflict The pull request has a merge conflict with the target branch label Jun 3, 2024

vicente-romero-oracle reviewed Jun 4, 2024

View reviewed changes

openjdk Bot removed the merge-conflict The pull request has a merge conflict with the target branch label Jun 6, 2024

biboudis force-pushed the matchers-experiment branch from 6138923 to 5246297 Compare June 6, 2024 13:46

biboudis changed the title ~~Pattern Declarations~~ Compiler Prototyping for Deconstructors Jun 6, 2024

biboudis changed the title ~~Compiler Prototyping for Deconstructors~~ 8333725: Compiler Prototyping for Deconstructors Jun 6, 2024

biboudis force-pushed the matchers-experiment branch 2 times, most recently from bf45138 to 250d702 Compare June 6, 2024 14:12

vicente-romero-oracle reviewed Jun 6, 2024

View reviewed changes

biboudis force-pushed the matchers-experiment branch from 250d702 to a19eff9 Compare June 6, 2024 21:13

8333725: Compiler Prototyping for Deconstructors

4c7b0ba

Co-authored-by: Angelos Bimpoudis <angelos.bimpoudis@oracle.com> Co-authored-by: Jan Lahoda <jan.lahoda@oracle.com> Co-authored-by: Vicente Romero <vicente.romero@oracle.com>

biboudis force-pushed the matchers-experiment branch from a19eff9 to 4c7b0ba Compare June 7, 2024 07:42

Fix translation of dtors with primitives and array types

61327bf

openjdk Bot added the merge-conflict The pull request has a merge conflict with the target branch label Jun 17, 2024

Merge remote-tracking branch 'refs/remotes/upstream-amber/master' int…

80a3f46

…o matchers-experiment # Conflicts: # src/java.base/share/classes/java/lang/Class.java

openjdk Bot removed the merge-conflict The pull request has a merge conflict with the target branch label Jun 17, 2024

biboudis added 2 commits June 17, 2024 16:14

Restore JTreg flag

875eb34

Address review 1/n

0eab5db

lahodaj added 3 commits June 4, 2025 11:34

The reflection does not need to go through Carriers.

47dd83d

Cleanup - removing unnecessary throws.

d2057fb

Simplifying reflection, as suggested

153efef

openjdk Bot added the merge-conflict The pull request has a merge conflict with the target branch label Jun 5, 2025

kevinb9n and others added 20 commits June 5, 2025 15:13

Goodbye to the PatternMember type parameter <T>

9e38517

Merge branch 'matchers-experiment' into matchers-experiment-instance-…

257ecfb

…pattern-parsing

Cleanup.

2724122

Fixing tests.

6fe4028

Fixing a crash when javac is highlighting a deconstructor

a3c86cd

Merge pull request #32 from lahodaj/fixing-crash-deconstructor

92e995b

Fixing a crash when javac is highlighting a deconstructor

Fix static patterns

452e43b

Fixing tests.

338175f

Merge pull request #30 from lahodaj/matchers-experiment-new-carriers

619b4aa

Carriers update for matchers-experiment

Merge branch 'matchers-experiment' into matchers-experiment-instance-…

c10f462

…pattern-parsing

Merge remote-tracking branch 'lahodaj-amber/matchers-experiment-insta…

2be479b

…nce-pattern-parsing' into matchers-experiment-instance-pattern-parsing

Adjust overloading and parsing

817bde3

Fixing some pattern/expression disambiguation and some tests.

cb62029

Fixing tests.

e6192b7

Merge branch 'matchers-experiment-instance-pattern-parsing' into matc…

4e7275b

…hers-experiment-instance-pattern-parsing-overloading

Fixing DeduplicationTest.

e6b9f0f

Merge branch 'matchers-experiment' into matchers-experiment-instance-…

6c11f67

…pattern-parsing

Fixing build.

2af05e0

Merge pull request #31 from lahodaj/matchers-experiment-instance-patt…

90dae0a

…ern-parsing An attempt to parse instance patterns more correctly.

Merge branch 'matchers-experiment' into matchers-experiment-instance-…

b5af36c

…pattern-parsing-overloading # Conflicts: # src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

biboudis added 3 commits July 30, 2025 17:09

Merge pull request #33 from biboudis/matchers-experiment-instance-pat…

69734a8

…tern-parsing-overloading Adjusting overloading + translation

Merge branch 'matchers-experiment-reflection-first' into matchers-exp…

2a703c7

…eriment

Drop generic parameter from Deconstructor

381a041

biboudis closed this Sep 6, 2025

Uh oh!

Conversation

biboudis commented May 13, 2024 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warnings

Issue

Reviewing

Uh oh!

bridgekeeper Bot commented May 13, 2024

Uh oh!

openjdk Bot commented May 13, 2024

Uh oh!

openjdk Bot commented May 13, 2024

Uh oh!

openjdk Bot commented May 13, 2024

Uh oh!

vicente-romero-oracle Jun 1, 2024

Choose a reason for hiding this comment

Uh oh!

vicente-romero-oracle Jun 1, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vicente-romero-oracle Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicente-romero-oracle Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

bridgekeeper Bot commented Jul 17, 2025

Uh oh!

Rick-24 commented Jul 17, 2025 via email • edited by bridgekeeper Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants

biboudis commented May 13, 2024 •

edited by openjdk Bot

Loading

Rick-24 commented Jul 17, 2025 via email •

edited by bridgekeeper Bot

Loading