Skip to content
This repository was archived by the owner on Jul 24, 2023. It is now read-only.

Commit b610dfd

Browse files
J5lxmarcoceppi
authored andcommitted
#145: Fix Auth_OpenID_SuccessResponse
In 263a6c7, @liayn made Auth_OpenID_ConsumerResponse::identity_url and Auth_OpenID_ConsumerResponse::endpoint private, then redeclared them as public in subclass Auth_OpenID_SuccessResponse, breaking functionality such as calling Auth_OpenID_ConsumerResponse::getDisplayIdentifier() on instances of Auth_OpenID_SuccessResponse. To fix that, I made the properties on Auth_OpenID_ConsumerResponse public as they were before and removed the redeclarations in Auth_OpenID_SuccessResponse.
1 parent 2b35711 commit b610dfd

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

Auth/OpenID/Consumer.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2076,10 +2076,10 @@ class Auth_OpenID_ConsumerResponse {
20762076
public $status = null;
20772077

20782078
/** @var null|string */
2079-
private $identity_url = null;
2079+
public $identity_url = null;
20802080

20812081
/** @var Auth_OpenID_ServiceEndpoint */
2082-
private $endpoint;
2082+
public $endpoint;
20832083

20842084
/**
20852085
* @param Auth_OpenID_ServiceEndpoint|null $endpoint
@@ -2138,10 +2138,6 @@ function getDisplayIdentifier()
21382138
class Auth_OpenID_SuccessResponse extends Auth_OpenID_ConsumerResponse {
21392139
public $status = Auth_OpenID_SUCCESS;
21402140

2141-
/** @var Auth_OpenID_ServiceEndpoint */
2142-
public $endpoint;
2143-
/** @var string */
2144-
public $identity_url;
21452141
/** @var array */
21462142
public $signed_args = array();
21472143
/** @var Auth_OpenID_Message */

0 commit comments

Comments
 (0)