Upgrade SpotBugs from 4.7.3 to 4.8.3 (#447) (#461)

This adds support for Java file version 65 (Java 21).

Changelog: https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md

Upgrade SpotBugs Maven plugin to 4.8.3.1.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>

Author: holgerfriedrich

docs/maven-plugin.md

@@ -117,8 +117,8 @@ Parameters:
 | **spotbugsRuleset** | String | Relative path to the XML that specifies the bug detectors which should be run. If not set the default file will be used|
 | **spotbugsInclude** | String | Relative path to the XML that specifies the bug instances that will be included in the report. If not set the default file will be used|
 | **spotbugsExclude** | String | Relative path to the XML that specifies the bug instances that will be excluded from the report. If not set the default file will be used|
-| **maven.spotbugs.version** | String | The version of the spotbugs-maven-plugin that will be used (default value is **4.6.0.0**) |
-| **spotbugs.version** | String | The version of SpotBugs that will be used (default value is **4.7.0**) |
+| **maven.spotbugs.version** | String | The version of the spotbugs-maven-plugin that will be used (default value is **4.8.3.1**) |
+| **spotbugs.version** | String | The version of SpotBugs that will be used (default value is **4.8.3**) |
 | **spotbugsPlugins** | List<Dependency> | A list with artifacts that contain additional detectors/patterns for SpotBugs |
 | **findbugs.slf4j.version** | String | The version of the findbugs-slf4j plugin that will be used (default value is **1.5.0**)|
 

pom.xml

@@ -69,7 +69,7 @@
     <maven.resources.version>3.3.0</maven.resources.version>
     <pmd.version>6.53.0</pmd.version>
     <checkstyle.version>10.6.0</checkstyle.version>
-    <spotbugs.version>4.7.3</spotbugs.version>
+    <spotbugs.version>4.8.3</spotbugs.version>
     <maven.core.version>3.6.0</maven.core.version>
     <maven.plugin.api.version>3.8.5</maven.plugin.api.version>
     <maven.plugin.annotations.version>3.7.0</maven.plugin.annotations.version>

sat-plugin/src/main/java/org/openhab/tools/analysis/tools/SpotBugsChecker.java

@@ -83,7 +83,7 @@ public class SpotBugsChecker extends AbstractChecker {
     /**
      * The version of the spotbugs-maven-plugin that will be used
      */
-    @Parameter(property = "maven.spotbugs.version", defaultValue = "4.6.0.0")
+    @Parameter(property = "maven.spotbugs.version", defaultValue = "4.8.3.1")
     private String spotbugsMavenPluginVersion;
 
     /**
@@ -95,7 +95,7 @@ public class SpotBugsChecker extends AbstractChecker {
     /**
      * The version of the spotbugs that will be used
      */
-    @Parameter(property = "spotbugs.version", defaultValue = "4.7.0")
+    @Parameter(property = "spotbugs.version", defaultValue = "4.8.3")
     private String spotBugsVersion;
 
     /**