Skip to content

Fix documentation PR preview #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 29, 2025

The openHABian sidebar entries added in #2434 break the Netlify preview build so some more placeholder files are necessary.

The openHABian sidebar entries added in openhab#2434 break the Netlify preview build so some more placeholder files are necessary.

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link

netlify bot commented Apr 29, 2025

Thanks for your pull request to the openHAB documentation! The result can be previewed at the URL below (this comment and the preview will be updated if you add more commits).

Built without sensitive environment variables

Name Link
🔨 Latest commit 894ccfb
🔍 Latest deploy log https://app.netlify.com/sites/openhab-docs-preview/deploys/6810818ef5a5e7000859f35b
😎 Deploy Preview https://deploy-preview-2491--openhab-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jimtng
Copy link
Contributor

jimtng commented Apr 29, 2025

Thanks!

@wborn
Copy link
Member Author

wborn commented May 1, 2025

Please review/merge this PR @openhab/documentation-maintainers 🙏

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wborn ! I wasn't aware of these placeholders in the repo. I had seen the problem during the openhabian PR but wouldn't know this part. Very helpful to know now.

@stefan-hoehn stefan-hoehn added this to the 5.0 milestone May 5, 2025
@stefan-hoehn stefan-hoehn merged commit d8967d9 into openhab:main May 5, 2025
4 checks passed
@wborn wborn deleted the fix-preview branch May 5, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants