createbuckets: Use mc alias set instead of mc config #1243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mc config` command was deprecated for a while, and has finally been removed in the most recent version of the `mc` client: minio/mc#5201 This change should therefore prevent (at least one source of) headaches should we want to upgrade the mc version in the docker-createbuckets Dockerfile in the future.
suricactus
approved these changes
May 28, 2025
Collaborator
suricactus
left a comment
suricactus
left a comment
There was a problem hiding this comment.
Thanks! Have not tested myself, but the CI did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mc configcommand was deprecated for a while, and has finally been removed in the most recent version of themcclient: minio/mc#5201So instead of
mc config host addwe should usemc alias set(according to MinIO Client docs)This change should therefore prevent (at least one source of) headaches should we eventually want to upgrade the
mcversion in thedocker-createbucketsDockerfile in the future.The most recent version of
mcwould fail like this for an attempt to usemc config: