Fix video emscripten #7637
Merged
Fix video emscripten #7637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ofTheo first I thought exactly that is the solution (for detecting audio), but then I saw it works for Safari only (deleted my comment because of that): |
Member
Author
|
ahh thanks @Jonathhhan - I can make it so it detects just for safari. |
Contributor
|
I have another Idea, to check it with the audio context. I will give it a try... |
Member
Author
|
awesome - thanks @Jonathhhan. feel free to do a PR for it if it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add in auto muting for emscripten
switch in mp4 for opencvPeopleDetection example to make compatible with emscripten
with these changes we should be good to
close #7627 #7626