Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openfaas/golang-http-template
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openfaas/golang-http-template
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: openfaasltd/sub-modules
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jan 24, 2020

  1. Workaround for #33 - go sub-modules 

    Fixes: #33

Go sub-modules do not work with this template, because the of
limitations on how local imports and the "replace" word works
in Go modules. You can only use "replace" in the root-level module
i.e. "main.go"

https://github.com/golang/go/wiki/Modules#gomod

This patch was tested with the following repo:

git@github.com:alexellis/golang-middleware-relative-import.git

* Documentation in the README has been updated
* Tested e2e and with a local "go test" in GOPATH with modules
turned on and Go 1.13
* Updated copy commands in Dockerfile so that they use a faster
mechanism, vs creating a new container step to chown (must be
tested with buildkit before merging, since buildkit did not like
this approach in the past when running as a restricted user at
runtime)

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    @alexellis
    alexellis committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    62fa9ba View commit details
    Browse the repository at this point in the history

  2. Remove verbose statement 

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    @alexellis
    alexellis committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    dbd7189 View commit details
    Browse the repository at this point in the history

  3. Update ordering of GO_REPLACE statements 

    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    @alexellis
    alexellis committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    c199c1a View commit details
    Browse the repository at this point in the history
Loading