Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Backports #8785

Merged
merged 13 commits into from
Jun 4, 2018
Merged

[beta] Backports #8785

merged 13 commits into from
Jun 4, 2018

Conversation

andresilva
Copy link
Contributor

tomaka and others added 5 commits June 4, 2018 13:58
* Fix #8468

* Use U256::max_value() instead

* Fix again

* Also change initial transaction gas
* Start dividing sync chain : first supplier method

* WIP - updated chain sync supplier

* Finish refactoring the Chain Sync Supplier

* Create Chain Sync Requester

* Add Propagator for Chain Sync

* Add the Chain Sync Handler

* Move tests from mod -> handler

* Move tests to propagator

* Refactor SyncRequester arguments

* Refactoring peer fork header handler

* Fix wrong highest block number in snapshot sync

* Small refactor...

* Resume warp-sync downloaded chunks

* Add comments

* Refactoring the previous chunks import

* Fix tests

* Address PR grumbles

* Fix not seeding current snapshot

* Address PR Grumbles

* Address PR grumble

* Retry failed CI job

* Update SnapshotService readiness check
Fix restoration locking issue for previous chunks restoration

* Fix tests

* Fix tests

* Fix test

* Early abort importing previous chunks

* PR Grumbles

* Update Gitlab CI config

* SyncState back to Waiting when Manifest peers disconnect

* Move fix

* Better fix

* Revert GitLab CI changes

* Fix Warning

* Refactor resuming snapshots

* Fix string construction

* Revert "Refactor resuming snapshots"

This reverts commit 75fd4b5.

* Update informant log

* Fix string construction

* Refactor resuming snapshots

* Fix informant

* PR Grumbles

* Update informant message : show chunks done

* PR Grumbles

* Fix

* Fix Warning

* PR Grumbles
Since we start parity with the UI disabled per default now, opening the browser post installation will show an annoying error message, confusing the user. This patch removes opening the browser to prevent that annoyance.

fixes #8194
@andresilva andresilva added the A8-backport 🕸 Pull request is already reviewed well in another branch. label Jun 4, 2018
@5chdn 5chdn added this to the Patch milestone Jun 4, 2018
@5chdn 5chdn mentioned this pull request Jun 4, 2018
57 tasks
@5chdn 5chdn added the M4-core ⛓ Core client code / Rust. label Jun 4, 2018
@5chdn
Copy link
Contributor

5chdn commented Jun 4, 2018

Thanks. Does not compile though.

ngotchac and others added 4 commits June 4, 2018 15:09
* Shutdown the Snapshot Service when shutting down the runner

* Rename `service` to `client_service`

* Fix tests
* Update ethereum-types so `{:#x}` applies 0x prefix
* Set the request index to that of the current request

When setting up the chain of (two) requests to look up a block by hash, the second need to refer to the first. This fixes an issue where the back ref was set to the subsequent request, not the current one. When the requests are executed we loop through them in order and ensure the requests that should produce headers all match up. We do this by index so they better be right.

In other words: off by one.
tomusdrw and others added 4 commits June 4, 2018 15:59
* Custom Error Messages on ENFILE and EMFILE IO Errors

Add custom mapping of ENFILE and EMFILE IO Errors (Failure because of missing system resource) right when chaining ioError into ::util::Network::Error to improve Error Messages given to user

Note: Adds libc as a dependency to util/network

* Use assert-matches for more readable tests

* Fix Wording and consistency
* ci: Remove check for shared libraries in gitlab script

* ci: allow android arm build to fail
@5chdn 5chdn merged commit 7bf16cc into beta Jun 4, 2018
@5chdn 5chdn deleted the andre-beta-backports branch June 4, 2018 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-backport 🕸 Pull request is already reviewed well in another branch. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants