Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

eip100b #5027

Merged
merged 3 commits into from
Mar 27, 2017
Merged

eip100b #5027

merged 3 commits into from
Mar 27, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 25, 2017 •
edited
Loading

@debris debris requested a review from arkpar March 25, 2017 10:32
gavofyork
gavofyork previously requested changes Mar 25, 2017
View reviewed changes
ethcore/src/ethereum/ethash.rs Outdated
@@ -406,6 +412,8 @@ impl Ethash {
panic!("Can't calculate genesis block difficulty");
}

let parent_has_uncles = &sha3::SHA3_EMPTY_LIST_RLP == parent.uncles_hash();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is what you mean.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, you are right :)

@gavofyork gavofyork added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. M4-core ⛓ Core client code / Rust. labels Mar 25, 2017
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Mar 25, 2017
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 26, 2017
@gavofyork gavofyork merged commit 23d3b79 into master Mar 27, 2017
@gavofyork gavofyork deleted the eip100b branch March 27, 2017 09:42
@arkpar arkpar mentioned this pull request Apr 21, 2017
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork left review comments

@arkpar arkpar Awaiting requested review from arkpar

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @gavofyork @arkpar