Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Alltools docker image #9405

Open
holiman opened this issue Aug 23, 2018 · 9 comments
Open

Alltools docker image #9405

holiman opened this issue Aug 23, 2018 · 9 comments
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ M0-build 🏗 Building and build system. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Milestone

Comments

@holiman
Copy link
Contributor

holiman commented Aug 23, 2018

On docker hub, there seems to be only latest and stable built with any regularity (aside from release-builds). Afaiu, they're built off this dockerfile.

I would be very greatful if you could add another docker image to docker hub, alltools, which also contains parity-evm (and any other binaries that the build process can generate). A similar thing exists for geth, with ethereum/client-go:alltools-latest

@holiman
Copy link
Contributor Author

holiman commented Aug 23, 2018

Here's an example dockerfile that contains parity-evm:


# Taken from https://github.com/paritytech/parity-ethereum/blob/master/docker/alpine/Dockerfile
FROM alpine:edge AS builder

# show backtraces
ENV RUST_BACKTRACE 1

RUN apk add --no-cache \
  build-base \
  cargo \
  cmake \
  eudev-dev \
  linux-headers \
  perl \
  rust git

RUN git clone https://github.com/paritytech/parity-ethereum /parity
WORKDIR /parity
RUN cargo build --release --target x86_64-alpine-linux-musl --verbose -p evmbin
RUN strip target/x86_64-alpine-linux-musl/release/parity-evm


FROM alpine:edge

# show backtraces
ENV RUST_BACKTRACE 1

RUN apk add --no-cache \
  libstdc++ \
  eudev-libs \
  libgcc

RUN addgroup -g 1000 parity \
  && adduser -u 1000 -G parity -s /bin/sh -D parity

USER parity
COPY --chown=parity:parity --from=builder /parity/target/x86_64-alpine-linux-musl/release/parity-evm ./

#ENTRYPOINT ["./parity"]

@Tbaut Tbaut added Z1-question 🙋‍♀️ Issue is a question. Closer should answer. M0-build 🏗 Building and build system. labels Aug 23, 2018
@Tbaut Tbaut added this to the 2.1 milestone Aug 23, 2018
@5chdn 5chdn added F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow. and removed Z1-question 🙋‍♀️ Issue is a question. Closer should answer. labels Aug 23, 2018
@5chdn
Copy link
Contributor

5chdn commented Aug 23, 2018

Actually, it's worth to add all of our tools to the parity docker image instead of maintaining multiple docker images.

@holiman
Copy link
Contributor Author

holiman commented Aug 24, 2018

Definitely! Anyone who wants a smaller image can just use that complete image as the basis of a multistage build, and pick out the cherries.

@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@holiman
Copy link
Contributor Author

holiman commented Nov 20, 2018

Any progress here ? Would be really nice to have...

@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@5chdn 5chdn modified the milestones: 2.4, 2.5 Feb 21, 2019
@soc1c soc1c modified the milestones: 2.5, 2.6 Apr 2, 2019
@ordian ordian modified the milestones: 2.6, 2.7 Jul 12, 2019
@jam10o-new jam10o-new added the hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ label Oct 1, 2019
@sachincool
Copy link

@joshua-mir hey, Can I pick this up, I tried to do the same thing as said above in the example of ethereum/client-go:alltools-latest by simply Copying everything from the build release/*

As mentioned above, We can make multiple Stages in the multi stage build where the source builder is same, making multiple Enviroment Versions super fast and easy eg:

$ docker build -t parity:release . --target=release
$ docker build -t parity:dev . --target=dev
$ docker images
REPOSITORY                                      TAG                 IMAGE ID            CREATED              SIZE
parity                                          dev                 1ac06e094d18        48 seconds ago       562MB
parity                                          release             5e702377839b        About a minute ago   16.4MB

I added the file in scripts/docker/alpine/Dockerfile

@holiman
Copy link
Contributor Author

holiman commented May 25, 2020

Hey ho OE Team!
Could you please take a look at this? I suspect it would be pretty easy to fix this, once you've set up a pipeline for building/pushing docker images

@adria0 adria0 added the A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 27, 2020
@adria0 adria0 closed this as completed Jul 27, 2020
@holiman
Copy link
Contributor Author

holiman commented Jul 27, 2020 via email

@adria0
Copy link

adria0 commented Jul 27, 2020

Hi @holiman, we have been closing - to be honest in a very direct - way a lot of issues to check if they are still relevant for users.

@denisgranha, any input on this?

@adria0 adria0 reopened this Jul 27, 2020
@denisgranha
Copy link

hey! we can add it when we add also another docker images for debian, etc

Not in the next days and I'll be on Holidays soon.

End of August we could add some improvements on the docker images

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-stale 🍃 Pull request did not receive any updates in a long time. No review needed at this stage. Close it. F8-enhancement 🎊 An additional feature request. hacktoberfest Join us for hacktoberfest - https://substrate.dev/hacktoberfest/ M0-build 🏗 Building and build system. P7-nicetohave 🐕 Issue is worth doing eventually. Q2-easy 💃 Can be fixed by copy and pasting from StackOverflow.
Projects
None yet
Development

No branches or pull requests

9 participants