Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Add blockHash option to eth_getLogs (EIP 234) #9251

Closed
fabioberger opened this issue Jul 30, 2018 · 4 comments
Closed

Add blockHash option to eth_getLogs (EIP 234) #9251

fabioberger opened this issue Jul 30, 2018 · 4 comments
Labels
F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API.
Milestone

Comments

@fabioberger
Copy link

fabioberger commented Jul 30, 2018

As described in EIP 234, eth_getLogs currently only supports querying logs by block number and not block hash.

This makes it impossible to know whether the logs returned are from the expected block, or if a block-reorg happened and the logs returned are actually from another block. Help!

Since the EIP's acceptance, the blockHash param has been added to the official Ethereum JSON RPC docs.

Geth also recently implemented EIP 234 (ethereum/go-ethereum#16734), would it be possible for Parity to do the same?

Getting a reliable stream of logs, regardless of re-orgs is not possible without this change.

@fabioberger fabioberger changed the title Add blockHash option to eth_getLogs (EIP 597) Add blockHash option to eth_getLogs (EIP 234) Jul 30, 2018
@avonian
Copy link

avonian commented Jul 30, 2018

this is a serious problem affecting my projects as well

@MicahZoltu
Copy link
Contributor

Killing Augur at the moment as well.

@nionis
Copy link

nionis commented Aug 1, 2018

EIP 234 helps alot with quarantining consistency of state due to reorgs when using indexers, right now the only alternative has a bandwidth trade off

@Tbaut Tbaut added Z1-question 🙋‍♀️ Issue is a question. Closer should answer. M6-rpcapi 📣 RPC API. labels Aug 6, 2018
@Tbaut Tbaut added this to the 2.1 milestone Aug 6, 2018
@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn 5chdn modified the milestones: 2.2, 2.3 Oct 29, 2018
@5chdn 5chdn modified the milestones: 2.3, 2.4 Jan 10, 2019
@jam10o-new jam10o-new added F8-enhancement 🎊 An additional feature request. and removed Z1-question 🙋‍♀️ Issue is a question. Closer should answer. labels Feb 20, 2019
@jam10o-new
Copy link
Contributor

I'm assuming this issue has been addressed by #9256? Correct me otherwise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F8-enhancement 🎊 An additional feature request. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

No branches or pull requests

7 participants