Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Sweep panics #386

Closed
gavofyork opened this issue Feb 9, 2016 · 1 comment
Closed

Sweep panics #386

gavofyork opened this issue Feb 9, 2016 · 1 comment
Labels
F6-refactor 📚 Code needs refactoring. Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate.
Milestone
1.4 Civility

Comments

@gavofyork
Copy link
Contributor

Panics should only be used in one circumstance:

  • to indicate a logical impossibility in the code (in which case this should be expect with an appropriate explanation as to why it is impossible, unless it's completely obvious).

All other panics and panic-causing code should be removed from non-test code.
@gavofyork gavofyork added F6-refactor 📚 Code needs refactoring. P9-somedaymaybe 🌞 Issue might be worth doing eventually. labels Feb 9, 2016
@gavofyork gavofyork added this to the 1.0 Parity milestone Feb 9, 2016
@NikVolf NikVolf self-assigned this Feb 9, 2016
@debris debris mentioned this issue Feb 27, 2016
Closed
@gavofyork gavofyork removed this from the 1.0 Parity milestone Mar 2, 2016
@gavofyork gavofyork modified the milestone: 1.3 Acuity Jul 7, 2016
@gavofyork gavofyork modified the milestones: 1.3 Acuity, 1.4 Civility Jul 30, 2016
@gavofyork
Copy link
Contributor Author

duplicate of #1026

@gavofyork gavofyork added Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate. and removed P9-somedaymaybe 🌞 Issue might be worth doing eventually. labels Aug 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F6-refactor 📚 Code needs refactoring. Z7-duplicate 🖨 Issue is a duplicate. Closer should comment with a link to the duplicate.
Projects
None yet
Milestone
1.4 Civility
Development

No branches or pull requests
2 participants
@gavofyork @NikVolf