Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Backport code structure changes #11241

Closed
10 tasks
seunlanlege opened this issue Nov 5, 2019 · 2 comments
Closed
10 tasks

Backport code structure changes #11241

seunlanlege opened this issue Nov 5, 2019 · 2 comments
Assignees
Labels
M4-core ⛓ Core client code / Rust. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.

Comments

@seunlanlege
Copy link
Member

Ok, so the master branch and stable/beta branches have diverged significantly in code structure so much so that backporting #11212 felt very surgical. Crates like client-traits, engines etc don't exist on the stable/beta. So any PR's that depend on that code would be a nightmare to backport.

So basically we need to backport these PR's so backporting future PR's based on master to stable

@seunlanlege seunlanlege added Q7-involved 💪 Can be fixed by a team of developers and probably takes some time. M4-core ⛓ Core client code / Rust. labels Nov 5, 2019
@seunlanlege seunlanlege self-assigned this Nov 5, 2019
@niklasad1
Copy link
Collaborator

niklasad1 commented Nov 5, 2019

/cc @dvdplm is this worth the effort?

EDIT: I think this would require us to cherry-pick almost all commits but I might be wrong

@dvdplm
Copy link
Collaborator

dvdplm commented Nov 5, 2019

No, definitely not worth it. The upcoming 2.5.10 is the last in the 2.5 series and we’re mainly concerned with the Istanbul block numbers. Anything else is “backport if easy, else skip it”.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M4-core ⛓ Core client code / Rust. Q7-involved 💪 Can be fixed by a team of developers and probably takes some time.
Projects
None yet
Development

No branches or pull requests

3 participants