Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatesgarth-next] gpsd: backport d-bus message time patch from upstream #331

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
From c9cec2a888d4fea8534be78a0f46d920155ceae6 Mon Sep 17 00:00:00 2001
From: Paul Fertser <fercerpav@gmail.com>
Date: Wed, 4 Nov 2020 12:40:50 -0800
Subject: [PATCH] gpsd/dbusexport.c: Fix broken d-bus message time.

Change-Id: I4b9990ce4517a8feb29fc9e090c62f5a0c56ddd5
---
dbusexport.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dbusexport.c b/dbusexport.c
index 40b35739e..5d08a8702 100644
--- a/dbusexport.c
+++ b/dbusexport.c
@@ -38,6 +38,7 @@ void send_dbus_fix(struct gps_device_t *channel)
/*DBusMessageIter iter; */
dbus_uint32_t serial; /* collected, but not used */
char *gpsd_devname;
+ double dtime; // time as a double, loss of precision!

/* if the connection is non existent, return without doing anything */
if (connection == NULL)
@@ -51,8 +52,9 @@ void send_dbus_fix(struct gps_device_t *channel)
/* the dbus/locationd doc fails to specify altitude as WGS84 or MSL.
* assume altMSL */
message = dbus_message_new_signal("/org/gpsd", "org.gpsd", "fix");
+ dtime = TSTONS(&gpsfix->time);
dbus_message_append_args(message,
- DBUS_TYPE_DOUBLE, &(gpsfix->time),
+ DBUS_TYPE_DOUBLE, &dtime,
DBUS_TYPE_INT32, &(gpsfix->mode),
DBUS_TYPE_DOUBLE, &(gpsfix->ept),
DBUS_TYPE_DOUBLE, &(gpsfix->latitude),
--
2.20.1

1 change: 1 addition & 0 deletions meta-oe/recipes-navigation/gpsd/gpsd_3.20.bb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ PROVIDES = "virtual/gpsd"
SRC_URI = "${SAVANNAH_GNU_MIRROR}/${BPN}/${BP}.tar.gz \
file://0001-SConstruct-prefix-includepy-with-sysroot-and-drop-sy.patch \
file://0001-Revert-SConstruct-Add-test-for-sizeof-time_t-result-.patch \
file://0001-gpsd-dbusexport.c-Fix-broken-d-bus-message-time.patch \
file://gpsd.init \
"
SRC_URI[md5sum] = "cf7fdec7ce7221d20bee1a7246362b05"
Expand Down