Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireshark: typo in zstd package config #845

Open
FederAndInk opened this issue Jul 18, 2024 · 1 comment
Open

wireshark: typo in zstd package config #845

FederAndInk opened this issue Jul 18, 2024 · 1 comment

Comments

@FederAndInk
Copy link

meta-openembedded/meta-networking/recipes-support/wireshark/wireshark_4.2.6.bb

Line 45 in f834285

PACKAGECONFIG[zstd] = "-DENABLE_STTD=ON,-DENABLE_ZSTD=OFF, zstd"

-DENABLE_STTD=ON should be -DENABLE_ZSTD=ON

- PACKAGECONFIG[zstd] = "-DENABLE_STTD=ON,-DENABLE_ZSTD=OFF, zstd" 
+ PACKAGECONFIG[zstd] = "-DENABLE_ZSTD=ON,-DENABLE_ZSTD=OFF, zstd"
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Oct 2, 2024
@gmange @kraj
wireshark: fix typo in PACKAGECONFIG[zstd]
1575853 
ENABLE_STTD is a typo, correct option is ENABLE_ZSTD.

This patches the following CMake warning in do_configure:
  Manually-specified variables were not used by the project: ENABLE_STTD
After, do_configure does not show the warning.

Github issue: openembedded#845

Reported-by: Ludovic Jozeau <ludovic.jozeau@smile.fr>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mange@smile.fr>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue Oct 5, 2024
@gmange @kraj
src/meta-openembedded:wireshark: fix typo in PACKAGECONFIG[zstd]
a1f010f 
ENABLE_STTD is a typo, correct option is ENABLE_ZSTD.

This patches the following CMake warning in do_configure:
  Manually-specified variables were not used by the project: ENABLE_STTD
After, do_configure does not show the warning.

Github issue: openembedded/meta-openembedded#845

Reported-by: Ludovic Jozeau <ludovic.jozeausmile.fr>
Reviewed-by: Yoann Congal <yoann.congalsmile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mangesmile.fr>
Signed-off-by: Khem Raj <raj.khemgmail.com>
@gmange
Copy link
Contributor

gmange commented Oct 8, 2024

Fixed with merged commit: https://git.openembedded.org/meta-openembedded/commit/?id=15758538ee4de90c146199ef831205f942786c8f

github-actions bot pushed a commit to Boeing/meta-openembedded-contrib that referenced this issue Oct 15, 2024
@gmange @akuster
wireshark: fix typo in PACKAGECONFIG[zstd]
5051819 
ENABLE_STTD is a typo, correct option is ENABLE_ZSTD.

This patches the following CMake warning in do_configure:
  Manually-specified variables were not used by the project: ENABLE_STTD
After, do_configure does not show the warning.

Github issue: openembedded/meta-openembedded#845

Reported-by: Ludovic Jozeau <ludovic.jozeau@smile.fr>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mange@smile.fr>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 1575853)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Nov 9, 2024
@gmange @akuster
wireshark: fix typo in PACKAGECONFIG[zstd]
eddd580 
ENABLE_STTD is a typo, correct option is ENABLE_ZSTD.

This patches the following CMake warning in do_configure:
  Manually-specified variables were not used by the project: ENABLE_STTD
After, do_configure does not show the warning.

Github issue: #845

Reported-by: Ludovic Jozeau <ludovic.jozeau@smile.fr>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mange@smile.fr>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 1575853)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
halstead pushed a commit that referenced this issue Nov 19, 2024
@gmange @kraj
wireshark: fix typo in PACKAGECONFIG[zstd]
c68342e 
ENABLE_STTD is a typo, correct option is ENABLE_ZSTD.

This patches the following CMake warning in do_configure:
  Manually-specified variables were not used by the project: ENABLE_STTD
After, do_configure does not show the warning.

Github issue: #845

Reported-by: Ludovic Jozeau <ludovic.jozeau@smile.fr>
Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
Signed-off-by: Ghislain Mangé <ghislain.mange@smile.fr>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 1575853)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmange @FederAndInk