feat!: add design tokens support #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tokens Sync master to design tokens
Conflicts: src/courseware/course/sidebar/common/SidebarBase.scss src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss src/courseware/course/sidebar/sidebars/discussions/Discussions.scss src/index.scss
…gn-tokens-sync sync `master` -> `master-design-tokens`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1737 +/- ##
==========================================
- Coverage 90.45% 90.45% -0.01%
==========================================
Files 344 344
Lines 5804 5803 -1
Branches 1398 1397 -1
==========================================
- Hits 5250 5249 -1
Misses 535 535
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sync `master` -> `master-design-tokens`
adamstankiewicz
approved these changes
Jun 18, 2025
Asespinel
pushed a commit
to eduNEXT/frontend-app-learning
that referenced
this pull request
Jul 30, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
nsprenkle
pushed a commit
to edx/frontend-app-learning
that referenced
this pull request
Aug 14, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
nsprenkle
added a commit
to edx/frontend-app-learning
that referenced
this pull request
Aug 15, 2025
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Brian Smith <112954497+brian-smith-tcril@users.noreply.github.com> Co-authored-by: Diana Olarte <diana.olarte@edunext.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Pre-design-tokens theming is no longer supported.
LAND AS SQUASH
The
master-design-tokensbranches were created as long running feature branches to ensure design tokens land on all MFEs simultaneously. These have been kept up to date via merge commits and should land on their respective MFEmasterbranches as a single squashed commit.master->master-design-tokens#1738