sync master -> master-design-tokens
#1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GH workflow that includes issues into the BTR board after the issue is labeled with `release testing`. Also add label needs triage for bug triaging issues.
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
* fix: prev and next buttons were not propertly centered and aligned * fix: removing flex-basis property for navigation buttons
Bumps and [tar-fs](https://github.com/mafintosh/tar-fs). These dependencies needed to be updated together. Updates `tar-fs` from 2.1.2 to 3.0.9 - [Commits](mafintosh/tar-fs@v2.1.2...v3.0.9) Updates `tar-fs` from 3.0.8 to 3.0.9 - [Commits](mafintosh/tar-fs@v2.1.2...v3.0.9) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 3.0.9 dependency-type: indirect - dependency-name: tar-fs dependency-version: 3.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* feat: base modifications to disable completion checks when flag enabled * chore: started updating tests * chore: udpated tests * chore: added missing negative test --------- Co-authored-by: Adolfo R. Brandes <adolfo@axim.org>
Adds an event handler on the window resize to check if the sidebar isOpen and the size of the viewport is smaller than the sidebar display to hide the sidebar and prevent it from blocking the course view.
…ar (openedx#1705)" (openedx#1712) This reverts commit 2ce8333.
When content within a sequence was shorter than the height of the browser viewport, the `.sequence-container > .outline-sidebar-wrapper` element does not expand appropriately. This caused the course outline sidebar to be partially or completely hidden from view.
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
* fix: fixed right panel closing issue * fix: fixed status of notificationTrayStatus in session storage * test: added test cases to close or open notification tray
Conflicts: src/courseware/course/sidebar/common/SidebarBase.scss src/courseware/course/sidebar/sidebars/course-outline/CourseOutlineTray.scss src/courseware/course/sidebar/sidebars/discussions/Discussions.scss src/index.scss
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #1733 +/- ##
=======================================================
Coverage ? 90.45%
=======================================================
Files ? 344
Lines ? 5803
Branches ? 1356
=======================================================
Hits ? 5249
Misses ? 537
Partials ? 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
merged commit 8331e51
into
openedx:master-design-tokens
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LAND AS MERGE COMMIT