Skip to content

fix: fixed right panel closing issue #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsprenkle merged 3 commits into from
Jun 13, 2025
Merged

fix: fixed right panel closing issue #1732

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180ac8e
fix: fixed right panel closing issue
sundasnoreen12 Jun 11, 2025
0067550
fix: fixed status of notificationTrayStatus in session storage
sundasnoreen12 Jun 12, 2025
4849d48
test: added test cases to close or open notification tray
sundasnoreen12 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/courseware/course/new-sidebar/SidebarContextProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ const SidebarProvider: React.FC<Props> = ({
}, [courseId]);

useEffect(() => {
window.sessionStorage.setItem('hideCourseOutlineSidebar', 'true');
window.sessionStorage.setItem(`notificationTrayStatus.${courseId}`, 'open');
setHideDiscussionbar(!isDiscussionbarAvailable);
setHideNotificationbar(!isNotificationbarAvailable);
if (initialSidebar && currentSidebar !== initialSidebar) {
Expand Down
1 change: 1 addition & 0 deletions src/courseware/course/sidebar/sidebars/course-outline/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export const useCourseOutlineSidebar = () => {
} else {
toggleSidebar(ID);
window.sessionStorage.removeItem('hideCourseOutlineSidebar');
window.sessionStorage.setItem(`notificationTrayStatus.${courseId}`, 'closed');
}
};

Expand Down