chore: re-add query-string dependency

[nsprenkle]

#1676 removed the query-string package. Several of our plugins still rely on this, though it should still be removed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.41%. Comparing base (b1ee8a3) to head (642c69a).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1703   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files         343      343           
  Lines        5779     5779           
  Branches     1346     1387   +41     
=======================================
  Hits         5225     5225           
+ Misses        537      535    -2     
- Partials       17       19    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bradenmacdonald]

Fine as a hotfix, but if the plugins depend on something like query-string they should be fixed to specify that in their own package.json dependencies.

[nsprenkle]

Fine as a hotfix, but if the plugins depend on something like query-string they should be fixed to specify that in their own package.json dependencies.

Question, our plugins do currently specify this as below but are still breaking. Is there a different way to specify that dependency that would cause it not to break?

    "peerDependencies": {
        ....
        "query-string": "*",
        "react": "*"
        ...
    },

[nsprenkle]

Fine as a hotfix, but if the plugins depend on something like query-string they should be fixed to specify that in their own package.json dependencies.

Question, our plugins do currently specify this as below but are still breaking. Is there a different way to specify that dependency that would cause it not to break?

    "peerDependencies": {
        ....
        "query-string": "*",
        "react": "*"
        ...
    },

Which is to say, in my mind this should work, but what I'm observing is that it isn't sufficient to actually ensure those dependencies are installed, based on how our framework / builds are setup.

[bradenmacdonald]

I would have thought that would be enough. Perhaps the plugins aren't being installed correctly?