Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: revert: "test: Remove support for Node 18 (#736)" #744

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Oct 31, 2024

This reverts commit 472bbe2 (#740).

@brian-smith-tcril brian-smith-tcril changed the title Reapply "test: Remove support for Node 18 (#736)" (#740) Reapply "test: Remove support for Node 18 (#736)" Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (79a2fa4) to head (8be6471).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files         161      161           
  Lines        3404     3404           
  Branches      914      919    +5     
=======================================
  Hits         3172     3172           
  Misses        215      215           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril changed the title Reapply "test: Remove support for Node 18 (#736)" Revert: Revert: "test: Remove support for Node 18 (#736)" Oct 31, 2024
@brian-smith-tcril brian-smith-tcril changed the title Revert: Revert: "test: Remove support for Node 18 (#736)" revert: revert: "test: Remove support for Node 18 (#736)" Oct 31, 2024
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brian-smith-tcril brian-smith-tcril merged commit af6cd18 into openedx:master Nov 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants